dgb: pin embedded tx-select feerate-order + weight-cap skip (Phase B FEED conformance) - #277
Merged
Merged
Conversation
…FEED conformance) Two KATs over make_mempool_tx_source / get_sorted_txs_with_fees: - EmitsFeerateDescendingOrder: transactions[] emitted highest-feerate-first (m_feerate_index is std::greater-ordered), matching the order Core GBT / p2pool-dgb-scrypt consume. - WeightCapSkipsHeavyButPacksLighter: over-cap high-feerate tx is skipped (continue, not break) while a lighter lower-feerate tx below it still packs; total_fees reflects only the packed tx. Test-only, src/impl/dgb/ only, non-consensus, no p2pool-merged-v36 surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase B FEED conformance: pins the ordering + weight-cap behaviour of the embedded mempool tx selector (get_sorted_txs_with_fees / make_mempool_tx_source) against the p2pool-dgb-scrypt / Core GBT contract.
Two new KATs in dgb_embedded_tx_select_test:
Scope: test-only, src/impl/dgb/ only, non-consensus, zero p2pool-merged-v36 surface, GPG-signed. In both build.yml --target allowlists already (existing target). 5/5 green locally.
Profile: fenced auto-merge.