dgb: wire faithful #82 reconstruct closure into the run-loop (replace nullopt stub) - #281
Merged
Merged
Conversation
… nullopt stub) main_dgb.cpp --run binds tracker().m_on_block_found to the FAITHFUL make_reconstruct_closure_from_template (#280) in place of the interim nullopt stub. The three version-agnostic won-block inputs are bound to the live sharechain tracker: - won_share_fields_fn: share.m_min_header + m_merkle_link (#279) - gentx_bytes_fn: generate_share_transaction(...).GentxCoinbase.bytes (#173 SSOT); v36_active re-derived from the share compile-time version inside GST, byte-identical to the verify-path invocation - template_other_txs_fn: captured-GBT non-coinbase set (#271), empty today (no per-job template retention + unfed embedded mempool => coinbase-only), correct-and-empty, NOT fail-closed Fires on the compute thread already holding the tracker lock, so the fns read tracker().chain directly (no read_tracker(), no self-deadlock). Fail-closed end to end: any builder error -> nullopt (announce + audit; RPC submitblock fallback still fires). Fenced to main_dgb.cpp; build EXIT=0; selftest OK. #82 OPEN pending a live UpdateTip won-block test.
frstrtr
added a commit
that referenced
this pull request
Jun 23, 2026
dgb: wire faithful #82 reconstruct closure into the run-loop (replace nullopt stub)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
main_dgb.cpp --runnow bindstracker().m_on_block_foundto the FAITHFULmake_reconstruct_closure_from_template(#280) in place of the interimreturn nulloptstub. Three version-agnostic won-block inputs, bound to the LIVE sharechain tracker:share.m_min_header+m_merkle_link(dgb: won_share_inputs seam — share-side half of #82 faithful reconstruct closure #279, verbatim)generate_share_transaction(...).GentxCoinbase.bytes(dgb(#82): expose SSOT gentx bytes for won-block reconstruction #173 SSOT);v36_activere-derived from the share compile-time version inside GST (share_check.hpp:943), byte-identical to the verify-path invocation (share_check.hpp:1728)Threading / safety
Fires on the COMPUTE thread already holding the tracker lock (attempt_verify -> m_on_block_found, share_tracker.hpp:537), so the fns read
tracker().chainDIRECTLY and do NOT takeread_tracker()(would self-deadlock — corrected consume-seam audit). Fail-closed end to end: any builder error ->nullopt(announce + audit; the RPC submitblock fallback still fires independently).Scope / fence
src/c2pool/main_dgb.cpp. No consensus / share-format / PPLNS surface; p2pool-merged-v36 surface NONE.