nmc(PF): retire stale TO-CONFIRM banner; params are pinned - #284
Merged
Conversation
…262/#264 + 2b-ii) The merge-mining consensus-parameters block-header comment still claimed NONE of the fields were committed and were placeholder sentinels pending pinning. That is stale: auxpow_activation_height (#258), pow_limit + genesis_hash (#261/#262), aux_chain_id (#264) and p2p_magic (2b-ii) are all pinned against namecoin-core chainparams.cpp and cross-checked on the synced .140 namecoind, with per-field provenance in the inline comments. Comment-only; fenced to src/impl/nmc/. Brings the conformance doc-state in line with the pinned reality so a reader does not wrongly conclude the params are unbaked.
frstrtr
added a commit
that referenced
this pull request
Jun 23, 2026
…262/#264 + 2b-ii) (#284) The merge-mining consensus-parameters block-header comment still claimed NONE of the fields were committed and were placeholder sentinels pending pinning. That is stale: auxpow_activation_height (#258), pow_limit + genesis_hash (#261/#262), aux_chain_id (#264) and p2p_magic (2b-ii) are all pinned against namecoin-core chainparams.cpp and cross-checked on the synced .140 namecoind, with per-field provenance in the inline comments. Comment-only; fenced to src/impl/nmc/. Brings the conformance doc-state in line with the pinned reality so a reader does not wrongly conclude the params are unbaked. Co-authored-by: frstrtr <frstrtr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only, fenced to src/impl/nmc/. The merge-mining consensus-parameters block-header comment in header_chain.hpp still claimed NONE of the fields were committed (placeholder sentinels pending pinning). Stale: auxpow_activation_height (#258), pow_limit + genesis_hash (#261/#262), aux_chain_id (#264) and p2p_magic (2b-ii) are all pinned against namecoin-core chainparams.cpp and cross-checked on synced .140 namecoind; provenance lives in the per-field inline comments. This retires the contradictory banner so a reader does not wrongly conclude the params are unbaked.
No consensus value changes. Auto-merge-eligible (comment-only). I do not self-merge.