Skip to content

nmc(PF): retire stale TO-CONFIRM banner; params are pinned #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frstrtr merged 1 commit into from
Jun 20, 2026
Merged

nmc(PF): retire stale TO-CONFIRM banner; params are pinned #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/impl/nmc/coin/header_chain.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,10 +522,14 @@ struct NMCChainParams {

// ── Merge-mining consensus parameters ──
//
// TO-CONFIRM: NONE of the following are committed constants. They are
// placeholder sentinels pending pinning against Namecoin chainparams
// (CChainParams) + a live namecoind. Do NOT promote to consensus until
// verified.
// PINNED: every field below is now committed against namecoin-core
// src/kernel/chainparams.cpp and cross-checked on a live namecoind
// (synced .140). auxpow_activation_height (#258), pow_limit + genesis_hash
// (#261/#262), aux_chain_id (#264) and p2p_magic (2b-ii) all carry their
// per-field provenance in the inline comments. The earlier "placeholder
// sentinel / TO-CONFIRM" banner is retired; default sentinels (-1) remain
// only as a fail-safe so a hand-built Params never claims merge-mining is
// active off an unset value.
//
// auxpow_activation_height: the height at/after which a Namecoin block MAY
// (and on mainnet, MUST) carry an AuxPow. Historically cited as 19200 on
Expand Down
Loading