ci(dgb): COIN_DGB +AUX_DOGE=ON build arm — seam coverage for phase DA (#310 follow-up) - #312
Merged
Merged
Conversation
#310 landed the -DAUX_DOGE opt-in seam (option + add_compile_definitions in src/impl/dgb/CMakeLists.txt; #ifdef AUX_DOGE in coin/node.hpp) but nothing in CI exercises the flag-ON path, so the dual-parent stretch seam could rot dark between now and M3. Add a dedicated coin-dgb-auxdoge job that configures with -DCOIN_DGB=ON -DAUX_DOGE=ON and builds the c2pool-dgb binary, so the #ifdef AUX_DOGE seam is compiled on every PR. Default build (flag OFF) is unchanged and still covered by the linux + dgb-smoke jobs. Workflow file only; no source or shared-base touch. Stacked on dgb/ci-fix-build-yml-conflict-markers (#311) because that is the only clean build.yml base while master CI is red; rebase to master once #311 lands.
frstrtr
changed the base branch from
dgb/ci-fix-build-yml-conflict-markers
to
master
June 22, 2026 03:19
frstrtr
added a commit
that referenced
this pull request
Jun 23, 2026
…#312) #310 landed the -DAUX_DOGE opt-in seam (option + add_compile_definitions in src/impl/dgb/CMakeLists.txt; #ifdef AUX_DOGE in coin/node.hpp) but nothing in CI exercises the flag-ON path, so the dual-parent stretch seam could rot dark between now and M3. Add a dedicated coin-dgb-auxdoge job that configures with -DCOIN_DGB=ON -DAUX_DOGE=ON and builds the c2pool-dgb binary, so the #ifdef AUX_DOGE seam is compiled on every PR. Default build (flag OFF) is unchanged and still covered by the linux + dgb-smoke jobs. Workflow file only; no source or shared-base touch. Stacked on dgb/ci-fix-build-yml-conflict-markers (#311) because that is the only clean build.yml base while master CI is red; rebase to master once #311 lands. Co-authored-by: frstrtr <frstrtr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #310 (the AUX_DOGE opt-in seam) as integrator requested: a configure flag with no CI coverage rots silently.
What
Adds a dedicated
coin-dgb-auxdogejob that configures-DCOIN_DGB=ON -DAUX_DOGE=ONand builds thec2pool-dgbbinary, so the#ifdef AUX_DOGEseam insrc/impl/dgb/coin/node.hppis compiled on every PR. The flag is real:option(AUX_DOGE ...)+add_compile_definitions(AUX_DOGE)insrc/impl/dgb/CMakeLists.txt:29-32.Default build (flag OFF) is unchanged and still covered by the
linux+dgb smokejobs.Scope
.github/workflows/build.ymlonly (+62), no source / shared-base touchStacking
Based on
dgb/ci-fix-build-yml-conflict-markers(#311) — the only clean build.yml base while master CI is red. Retarget to master once #311 lands.