Skip to content

fix(dgb): P0 master-red — pin reconstruct test merkle_root to actual tx-vector root #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frstrtr merged 1 commit into from
Jun 22, 2026
Merged

fix(dgb): P0 master-red — pin reconstruct test merkle_root to actual tx-vector root #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/impl/dgb/test/reconstruct_won_block_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,20 @@ TEST(DgbReconstructWonBlock, CoinbaseFirstThenRefOrder)
BlockType blk;
ps >> blk;

EXPECT_EQ(blk.m_merkle_root, gh); // empty link => root == gentx_hash
ASSERT_EQ(blk.m_txs.size(), 3u); // gentx + 2 others
// Header merkle_root is recomputed over the ACTUAL block tx vector
// ([gentx_hash] ++ each other-tx txid), per the #303 bad-txnmrklroot fix --
// NOT the empty-merkle_link walk (which would yield gentx_hash alone). Pin
// header/body consistency via the same build_block_merkle_root SSOT.
{
std::vector<uint256> expect_txids = {
gh,
dgb::coin::compute_txid(blk.m_txs[1]),
dgb::coin::compute_txid(blk.m_txs[2]),
};
EXPECT_EQ(blk.m_merkle_root,
dgb::coin::build_block_merkle_root(expect_txids));
}
EXPECT_EQ(blk.m_txs[0].vin[0].prevout.index, 0xffffffffu); // coinbase at 0
EXPECT_TRUE(blk.m_txs[0].vin[0].prevout.hash.IsNull());
EXPECT_EQ(blk.m_txs[1].vout[0].value, 11); // c1 -> make_tx(11), ref order
Expand Down
Loading