dash: merkleRootQuorums (CbTx) computation leaf + bit-exact KATs (S7) - #325
Merged
Conversation
S7 quorum-root leaf between the LLMQ quorum-tail leaf (#321) and embedded_gbt main. Lands src/impl/dash/coin/quorum_root.hpp (compute_merkle_root_quorums over the QuorumManager active set, mirroring dashcore CalcCbTxMerkleRootQuorums) plus a self-contained test_dash_quorum_root.cpp pinning: - llmq_uses_rotation mainnet type flags (5,6 rotated); - hash_commitment == SHA256d(pack(CFinalCommitment)) frozen golden; - merkle primitives (empty/singleton/pair/odd-triple); - set selection: all non-rotated entries + rotated latest-per-index dedup, lexicographically-sorted SHA256d merkle, frozen root golden. End-to-end live-mnlistdiff cross-check deferred to Phase L. Fenced to src/impl/dash; wired into test/CMakeLists.txt and build.yml gtest + sanitizer target lists. 11/11 green Linux x86_64.
frstrtr
added a commit
that referenced
this pull request
Jun 23, 2026
…325) S7 quorum-root leaf between the LLMQ quorum-tail leaf (#321) and embedded_gbt main. Lands src/impl/dash/coin/quorum_root.hpp (compute_merkle_root_quorums over the QuorumManager active set, mirroring dashcore CalcCbTxMerkleRootQuorums) plus a self-contained test_dash_quorum_root.cpp pinning: - llmq_uses_rotation mainnet type flags (5,6 rotated); - hash_commitment == SHA256d(pack(CFinalCommitment)) frozen golden; - merkle primitives (empty/singleton/pair/odd-triple); - set selection: all non-rotated entries + rotated latest-per-index dedup, lexicographically-sorted SHA256d merkle, frozen root golden. End-to-end live-mnlistdiff cross-check deferred to Phase L. Fenced to src/impl/dash; wired into test/CMakeLists.txt and build.yml gtest + sanitizer target lists. 11/11 green Linux x86_64. Co-authored-by: frstrtr <frstrtr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S7 quorum-root leaf — next staged DASH slice after SimplifiedMNList (#309) and the LLMQ quorum-tail leaf (#321).
What
Lands
src/impl/dash/coin/quorum_root.hpp—compute_merkle_root_quorums()over the in-memoryQuorumManageractive set, mirroring dashcoreevo/cbtx.cpp::CalcCbTxMerkleRootQuorums. This is the CbTxmerkleRootQuorumsfield a built block template must carry for a Dash node to accept the coinbase special-tx payload — the last absent leaf feeding embedded_gbt main.Tests —
test_dash_quorum_root.cpp, 11/11 green Linux x86_64 (non-hollow)llmq_uses_rotationmainnet type flags (5/6 rotated, rest not);hash_commitment == SHA256d(pack(CFinalCommitment)), frozen wire-byte golden;Scope discipline
src/impl/dash/only — no shared / bitcoin_family / src/core changes (build.yml + test/CMakeLists.txt are the only non-dash files, each adding just the new target).Conforms vs frstrtr/p2pool-dash discipline. No self-merge — surfacing for integrator verify + operator tap.
head: ceb5378 (GPG-signed)