ltc: reconcile stale count-based comments on AutoRatchet tail-guard (code is work-weighted) - #368
Merged
Conversation
…code is work-weighted) The LTC AutoRatchet VOTING tail-guard calls get_desired_version_weights (auto_ratchet.hpp), i.e. it is WORK-weighted and coupled to the check()-phase 60% accept gate (mint strictly implies accept). Three comments asserted the opposite (flat-count / finding #1 count-based), contradicting the call site. Comment-only; no consensus-value change. - auto_ratchet.hpp: drop "stays inline and count-based (finding #1)" - share_tracker.hpp: drop "FLAT-COUNT variant"/"count-based per F10 finding #1" - share_check.hpp: drop "AutoRatchet stays count-based" No remaining flat-count tail-guard codepath: the only count fn (get_desired_version_counts) has no callers in src/impl/ltc; the comment described an intent the code never implemented. LTC is the canonical reference mirrored by dgb/dash/bch, so the prose now matches the work-weighted standard.
frstrtr
added a commit
that referenced
this pull request
Jun 23, 2026
…nt-reconcile ltc: reconcile stale count-based comments on AutoRatchet tail-guard (code is work-weighted)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only reconciliation. Three stale comments asserted the AutoRatchet tail guard was flat-count; the code (auto_ratchet.hpp:160, share_check.hpp:1779) calls get_desired_version_weights and couples activation to the check()-phase 60%-by-work accept gate (#288 mint<->accept coupling). The only count fn, get_desired_version_counts (share_tracker.hpp:2131), has zero callers in src/impl/ltc. Reconciled comments to the code. No consensus-value change, single LTC tree, GPG-signed (50AB1379). Verified by integrator.