btc: G0/G1 bake golden share-format fixture + parity KAT - #392
Merged
Conversation
Bake the BTC share-format baseline now that the fork pin is resolved to p2pool-btc-jtoomim @ ece15b03fc23. Emit the golden fixture via tools/conformance/extract_share_format.py (static extraction) and add a gtest KAT that asserts the c2pool BTC port against it. Bucket discipline (3-bucket rule): - Isolation primitives (IDENTIFIER/PREFIX/P2P_PORT/SEGWIT=33): byte-equal. - MINIMUM_PROTOCOL_VERSION: c2pool floor (3500) >= baseline (3301), an intentional forward-compatible raise, not a parity break. - share-versions additive-v36: boundary pinned by BTC_version_gate KAT. Rides the existing allowlisted btc_share_test exe (no new target, no build.yml change). btc_share_test 14/14 green; fixture re-emit MATCH 9/9.
…ate SSOT) Strengthen the G0/G1 share-format parity gate so an unsanctioned extra/ shifted share-version fails here, not only in the separate activation- boundary KAT. c2pool has no p2pool-style version array to compare element- wise, so the single sanctioned additive over the baseline [0,17,32,33,34,35] is locked against core::version_gate::V36_ACTIVATION_VERSION (==36) plus an exact-boundary check (36 active, 35 not). Baseline set transcribed from btc.g01.golden.json @ ece15b03fc23. Test-only, fenced to src/impl/btc/test.
frstrtr
force-pushed
the
btc/g01-bake-golden-parity-kat
branch
from
June 24, 2026 00:02
b663735 to
15fb06b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G0/G1 — bake the BTC share-format baseline + parity KAT
Now that the BTC fork pin is resolved to p2pool-btc-jtoomim @
ece15b03fc23, this bakes the share-format golden fixture and adds the KAT that fires G0/G1 byte-parity.What
tools/conformance/fixtures/btc.g01.golden.json— emitted by the existingtools/conformance/extract_share_format.py(static extraction, no execution of the py2 baseline) against the pinned jtoomim tree.-fadded (tools/ is gitignored).src/impl/btc/test/g01_share_format_parity_test.cpp— asserts the c2poolbtc::PoolConfigconstants against the baked golden.Bucket discipline (operator 3-bucket rule)
3500>= baseline3301: an intentional, forward-compatible floor raise (admits jtoomim-master/SPB, excludes forrestv-era v17/v32). Asserted>=, not==.[0..35]; the v36 activation boundary is pinned separately byBTC_version_gate.V36ActivationBoundary. Not re-asserted here.Fence / CI
btc_share_testexe (source added to that target) — no new executable, no build.yml change, avoiding the dgb: conform subsidy to p2pool-dgb-scrypt oracle (COIN=1e6, weeks+1) [COMPAT] #137 NOT_BUILT trap.Evidence
btc_share_test14/14 green (3 new BTC_g01_share_format cases).compare: MATCH 9/9 constants.eb5a61f2, GPG signed (signed=G).Held for operator tap — I do not self-merge.