dgb: correct won_share_inputs header drift -- m_on_block_found bound, not a nullopt stub - #437
Merged
Merged
Conversation
…und, not a nullopt stub The won_share_inputs.hpp banner described ShareTracker::m_on_block_found as "today an interim nullopt stub in main_dgb.cpp". That is stale: main_dgb.cpp now binds m_on_block_found = dgb::coin::make_on_block_found(...) -- the #82 dual-path broadcaster (P2P-relay arm + external-digibyted submitblock fallback), proven end-to-end on regtest. Comment-only; no code, behavior, consensus, share-format, or p2pool-merged-v36-surface change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Comment-only correction to
src/impl/dgb/coin/won_share_inputs.hpp. The banner describedShareTracker::m_on_block_foundas "today an interim nullopt stub in main_dgb.cpp". That is stale.main_dgb.cppnow bindsm_on_block_found = dgb::coin::make_on_block_found(...)-- the #82 dual-path broadcaster (P2P-relay arm + external-digibytedsubmitblockfallback), proven end-to-end on regtest (both arms accept a tx-bearing won block).Scope
src/impl/dgb/only.small_header,merkle_link); the other three are supplied template-side inreconstruct_closure.hpp.Fenced/additive doc fix. No self-merge.