Skip to content

web(currency_info): report LIVE ratchet share_version, not static 36 #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frstrtr merged 1 commit into from
Jun 25, 2026
Merged

web(currency_info): report LIVE ratchet share_version, not static 36 #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/core/web_server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4813,13 +4813,19 @@ nlohmann::json MiningInterface::rest_web_currency_info()

// p2pool share version for the current coin — consumed by the
// bundled @c2pool/sharechain-explorer to classify share cells.
// Dash = v16, LTC/DOGE/BTC = v36.
// For the V35/V36-ratcheting coins this MUST be the node's LIVE
// ratchet-selected version (m_cached_share_version, fed from the
// AutoRatchet), never a static 36: during the V35->V36 cross a node that
// is still VOTING is actually producing V35 shares, and reporting 36 would
// make the explorer misclassify live V35 share cells as V36 — a lie about
// the crossing state. DASH (v16, non-ratcheting on this path) keeps its
// protocol version since the LTC AutoRatchet does not drive its cache.
switch (m_blockchain) {
case Blockchain::DASH: result["share_version"] = 16; break;
case Blockchain::LITECOIN:
case Blockchain::BITCOIN:
case Blockchain::DOGECOIN:
default: result["share_version"] = 36; break;
default: result["share_version"] = m_cached_share_version; break;
}

// ─── Per-coin explorer map (operator 2026-06-23: each coin = a distinct
Expand Down
Loading