From 481ddba5921b1ba88a9226bf2584659fd0b87e91 Mon Sep 17 00:00:00 2001
From: frstrtr <frstrtr@users.noreply.github.com>
Date: Thu, 25 Jun 2026 16:43:34 +0000
Subject: [PATCH] web(version_signaling): show V35->V36 crossing banner on ALL
 ratcheting coins
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

rest_version_signaling() gated on a hardcoded {LITECOIN,DOGECOIN} allowlist,
returning an empty object for every other coin. But BTC/DGB/BCH are also
v36-ratcheting (each wires core::version_gate / AutoRatchet: #440 BTC, #293 DGB,
#255 BCH). On those nodes the dashboard crossing banner was suppressed entirely,
so an operator could not see the V35->V36 cross — a charter #3 blind spot
(operators must see the ratchet truthfully, cross-coin).

Invert the guard to exclude only static-version coins (Dash = v16), which
genuinely have no pending transition. Coins whose sharechain stats carry no
vote data fall through to the existing empty-result path below, so the banner
stays hidden until there is real crossing state — no false banners. Web-only,
non-consensus.
---
 src/core/web_server.cpp | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/core/web_server.cpp b/src/core/web_server.cpp
index 7950c03ad..4ca06fefc 100644
--- a/src/core/web_server.cpp
+++ b/src/core/web_server.cpp
@@ -5744,10 +5744,15 @@ nlohmann::json MiningInterface::rest_miner_payouts(const std::string& address)
 
 nlohmann::json MiningInterface::rest_version_signaling(const nlohmann::json* cached_sc)
 {
-    // V35→V36 transition tracking applies to the v36 coins (LTC and DOGE).
-    // Other blockchains (e.g. Dash v16) don't have a pending transition, so
-    // return an empty object to keep the dashboard's transition banners hidden.
-    if (m_blockchain != Blockchain::LITECOIN && m_blockchain != Blockchain::DOGECOIN)
+    // V35→V36 transition tracking applies to every v36-ratcheting coin
+    // (LTC/DOGE/BTC/DGB, plus BCH which reaches this path as its embedded base
+    // coin). Only static-version coins (Dash = v16) have no pending transition,
+    // so for those return an empty object to keep the crossing banner hidden.
+    // A prior hardcoded {LTC,DOGE} allowlist suppressed the crossing banner on
+    // BTC/DGB/BCH nodes mid-cross — a charter #3 blind spot. Coins whose
+    // sharechain stats carry no vote data simply fall through to an empty result
+    // below, so the banner stays hidden until there is real crossing state.
+    if (m_blockchain == Blockchain::DASH)
         return nlohmann::json::object();
 
     // Matches p2pool's get_version_signaling() — all fields the dashboard JS expects.