Skip to content

web(version_signaling): show V35->V36 crossing banner on ALL ratcheting coins (charter #3) #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frstrtr merged 1 commit into from
Jun 25, 2026
Merged

web(version_signaling): show V35->V36 crossing banner on ALL ratcheting coins (charter #3) #496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/core/web_server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5744,10 +5744,15 @@ nlohmann::json MiningInterface::rest_miner_payouts(const std::string& address)

nlohmann::json MiningInterface::rest_version_signaling(const nlohmann::json* cached_sc)
{
// V35→V36 transition tracking applies to the v36 coins (LTC and DOGE).
// Other blockchains (e.g. Dash v16) don't have a pending transition, so
// return an empty object to keep the dashboard's transition banners hidden.
if (m_blockchain != Blockchain::LITECOIN && m_blockchain != Blockchain::DOGECOIN)
// V35→V36 transition tracking applies to every v36-ratcheting coin
// (LTC/DOGE/BTC/DGB, plus BCH which reaches this path as its embedded base
// coin). Only static-version coins (Dash = v16) have no pending transition,
// so for those return an empty object to keep the crossing banner hidden.
// A prior hardcoded {LTC,DOGE} allowlist suppressed the crossing banner on
// BTC/DGB/BCH nodes mid-cross — a charter #3 blind spot. Coins whose
// sharechain stats carry no vote data simply fall through to an empty result
// below, so the banner stays hidden until there is real crossing state.
if (m_blockchain == Blockchain::DASH)
return nlohmann::json::object();

// Matches p2pool's get_version_signaling() — all fields the dashboard JS expects.
Expand Down
Loading