dgb: delegate diagnostic lookbehind clamps onto chain_walk_window SSOT (#423 follow-on) - #519
Merged
Merged
Conversation
#423 follow-on) Rewire the three DIAGNOSTIC-path lookbehind clamps in share_tracker.hpp (get_average_stale_prop, get_stale_counts, get_desired_version_counts flat-count) onto dgb::chain_walk_window_count / chain_walk_window_active (coin/chain_walk_window.hpp). Byte-identical: the helper returns the same std::min(lookbehind, height) value and the same (actual > 0) walk-activation guard; the static_cast<int32_t> stays at the call site exactly as before. The CONSENSUS-bearing get_desired_version_weights clamp (feeds the check()-phase 60%-by-work v36 switch gate, share_check step 2) is LEFT inline this slice and parked for a separate operator-surfaced tap, per the observation-only scope split. dgb_chain_walk_window_test 5/5 (incl. DelegationMatchesPreDelegationInline), dgb_share_test 34/34.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-on byte-identity rewire for the merged #423
chain_walk_windowSSOT. Delegates the three diagnostic-path lookbehind clamps inshare_tracker.hppontodgb::chain_walk_window_count/dgb::chain_walk_window_active:get_average_stale_prop(efficiency diag)get_stale_counts(efficiency diag)get_desired_version_counts(flat-count, diag/KAT only)Scope split (per integrator observation-only confirm, UID2552)
The consensus-bearing
get_desired_version_weightsclamp — which feeds thecheck()-phase 60%-by-work v36 switch gate (share_check step 2) — is LEFT inline and parked for a separate operator-surfaced tap. This slice cannot alter any number a peer computes for share or chain acceptance.Byte-identity
Helper returns the same
std::min(lookbehind, height)and the sameactual > 0walk-activation guard; thestatic_cast<int32_t>stays at the call site exactly as before.dgb_chain_walk_window_test5/5 (incl.DelegationMatchesPreDelegationInline)dgb_share_test34/34FENCED to
src/impl/dgb/. NO self-merge.