Skip to content

dgb: delegate diagnostic lookbehind clamps onto chain_walk_window SSOT (#423 follow-on) #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frstrtr merged 1 commit into from
Jun 26, 2026
Merged

dgb: delegate diagnostic lookbehind clamps onto chain_walk_window SSOT (#423 follow-on) #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/impl/dgb/share_tracker.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ inline uint64_t mul128_shift(uint64_t a, uint64_t b, unsigned shift) {
#include <impl/dgb/coin/desired_version_tally.hpp> // SSOT: accumulate_version_weights / accumulate_version_counts (#429 follow-on)
#include "coin/pool_attempts_per_second.hpp" // SSOT: compute_pool_attempts_per_second (#407 follow-on)
#include "coin/tail_score_endpoints.hpp" // SSOT: score_* endpoint arithmetic (ShareTracker::score chain-walk, #411 follow-on)
#include "coin/chain_walk_window.hpp" // SSOT: lookbehind clamp (#423 diag follow-on); consensus get_desired_version_weights stays inline
#include "config_pool.hpp"

#include <core/target_utils.hpp>
Expand Down Expand Up @@ -2059,8 +2060,8 @@ class ShareTracker
float get_average_stale_prop(const uint256& share_hash, uint64_t lookbehind)
{
auto height = chain.get_height(share_hash);
auto actual_lookbehind = std::min(static_cast<int32_t>(lookbehind), height);
if (actual_lookbehind <= 0)
auto actual_lookbehind = dgb::chain_walk_window_count(height, static_cast<int32_t>(lookbehind));
if (!dgb::chain_walk_window_active(actual_lookbehind))
return 0.0f;

float stale_count = 0;
Expand All @@ -2081,8 +2082,8 @@ class ShareTracker
{
StaleCounts counts;
auto height = chain.get_height(share_hash);
auto actual_lookbehind = std::min(static_cast<int32_t>(lookbehind), height);
if (actual_lookbehind <= 0)
auto actual_lookbehind = dgb::chain_walk_window_count(height, static_cast<int32_t>(lookbehind));
if (!dgb::chain_walk_window_active(actual_lookbehind))
return counts;

auto view = chain.get_chain(share_hash, actual_lookbehind);
Expand Down Expand Up @@ -2127,8 +2128,8 @@ class ShareTracker
if (!chain.contains(share_hash))
return {};
auto height = chain.get_height(share_hash);
auto actual = std::min(lookbehind, height);
if (actual <= 0)
auto actual = dgb::chain_walk_window_count(height, lookbehind);
if (!dgb::chain_walk_window_active(actual))
return {};

std::vector<uint64_t> window;
Expand Down
Loading