ci: PPLNS parse seed-pin regression guard (seed -1679627146) - #52
Merged
Conversation
Pin fast-check seed -1679627146 as a permanent CI replay. This is the counterexample that surfaced the non-finite legacy bare-number regression (input [Infinity] -> totalPrimary Infinity), fixed in PR #51. The random- seeded web-static job can pass without ever replaying this sequence, so a dedicated job preloads .ci-seed-pin.mjs to force the exact failing path on every change to the parser or its tests. Verified locally on master: pinned replay 13/13 pass; full suite 245/0/12.
Owner
Author
|
APPROVE — seed-pin regression guard (seed -1679627146). Negative control passed: temporarily reverted the PR #51 finite-clamp in num() (parse.ts:49, dropped the Number.isFinite check). Pinned-seed run went RED — 3/13 fail, incl. assert Number.isFinite(snap.totalPrimary) at pplns-parse-properties.test.ts:321. Restored clean tree (verified, no diff). On the clamp-intact tree the same suite is GREEN 13/13. The guard genuinely fails when the clamp regresses, so the pinned seed is a real teeth-bearing gate, not a no-op. LGTM to merge once A1 lands. — explorer-merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permanent regression guard for the PPLNS parse property suite.
What
Why
Seed -1679627146 is the counterexample that surfaced the non-finite legacy bare-number regression (input [Infinity] -> totalPrimary Infinity), fixed in PR #51. The random-seeded web-static job in build.yml passed 245/0 without ever replaying this exact sequence — exactly the gap that let the regression land. This job forces the failing path so a future random run can never again be green while the pinned sequence fails.
Verification (local, current master)
Guard only — no parser changes. Awaiting integrator review before merge.