dgb(phase-b): pin sharechain bits encoding to oracle-literal goldens - #554
Merged
Conversation
FENCED Phase-B conformance KAT (no production code touched). Pins the DGB sharechain share-difficulty bits (compact FloatingInteger) field against LITERAL goldens produced by the oracle reference encoder frstrtr/p2pool-dgb-scrypt bitcoin/data.py from_target_upper_bound, at the canonical retarget anchors: MAX_TARGET -> 0x1e0fffff, MAX_TARGET/30 -> 0x1e008888, MAX_TARGET/2 -> 0x1e07ffff, MIN_TARGET -> 0x00000000. Removes the SUT-vs-SUT circularity in dgb_share_target_genesis_test (which asserts compute_share_target == target_to_bits_upper_bound of the same target) by pinning the absolute on-wire compact value. Registered in this dir CMakeLists.txt and both build.yml --target allowlists (#143). 8/8 pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FENCED Phase-B conformance KAT — no production code touched (dgb/test + CI allowlist only).
Pins the DGB sharechain share-difficulty
bits(compact FloatingInteger) field against LITERAL goldens from the oracle reference encoderfrstrtr/p2pool-dgb-scryptbitcoin/data.pyfrom_target_upper_bound, at the canonical retarget anchors:Removes the SUT-vs-SUT circularity in
dgb_share_target_genesis_test(which only asserts compute_share_target == target_to_bits_upper_bound of the same target) by pinning the absolute on-wire compact value. Registered in this-dir CMakeLists.txt + both build.yml --target allowlists (#143). 8/8 pass locally. GPG-signed.Per-coin isolation: fenced to src/impl/dgb/. No self-merge.