d-miner5(fix): gate back_online on a reported outage (no false recovery on sub-threshold blip) - #558
Merged
Merged
Conversation
evaluate() emitted a back_online event whenever the prior sample was offline, regardless of whether an OFFLINE alert had actually fired. A sub-threshold blip (dark < offline_min) never fires OFFLINE, so the recovery edge would tell the miner they are back from an outage they were never told about and that never met the alert threshold -- a false-positive notification. Gate the back_online edge on offline_fired so a recovery is only reported when the outage itself was reported. Add KAT scenario 6b (blip-then-recover stays silent); selftest 10/10.
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
evaluate()in the D-MINER.5 notify engine emitted aback_onlineevent whenever the prior sample was offline (p_online == 0), regardless of whether anOFFLINEalert had ever fired.A sub-threshold blip — a worker dark for less than
offline_min— never firesOFFLINE. But on the next online sample the old code still emittedback_online, telling the miner they had recovered from an outage:That is a false-positive notification: the engine reporting a recovery from an outage it never reported. Same charter as the dashboard — the notify path must never tell a miner something untrue.
Fix
Gate the
back_onlineedge onoffline_fired, so a recovery is only reported when the outage itself was reported.Test
Adds KAT scenario 6b: a worker blips dark for 1m (< 15m threshold) then recovers — must stay silent (no
OFFLINE, no falseback_online). Verified the KAT fails before the fix and passes after.selftest10/10.Web/notify-engine layer only; non-consensus.