d-miner5(kat): pin throttle re-fire after window elapses - #567
Merged
Conversation
evaluate() emitted a back_online event whenever the prior sample was offline, regardless of whether an OFFLINE alert had actually fired. A sub-threshold blip (dark < offline_min) never fires OFFLINE, so the recovery edge would tell the miner they are back from an outage they were never told about and that never met the alert threshold -- a false-positive notification. Gate the back_online edge on offline_fired so a recovery is only reported when the outage itself was reported. Add KAT scenario 6b (blip-then-recover stays silent); selftest 10/10.
…observed peak)
Extends the D-MINER.5 notify-engine selftest to regression-lock the
HASHRATE_DROP edge cases, completing the per-kind honesty sweep
(offline/back_online/daily-summary already pinned):
6c first-online (peak==0 guard) must NEVER fire a drop -- a drop with
no observed prior peak is a fabricated alert.
6d a real halving vs the observed peak fires exactly one drop.
6e a dark (hashrate==0) sample is an OFFLINE concern, never a -100%
drop -- drop is evaluated in the online branch only.
Test-only / SAFE-ADDITIVE: pins existing honest behavior, no engine
logic change. Selftest 13/13.
…, never masquerade as handled)
… must never masquerade as permanent coverage) Completes the throttle-honesty triad with #8 (within-window suppress) and #8b/#563 (undelivered retries): once the throttle window has ELAPSED, a still-true condition (e.g. an ongoing outage) must re-fire. Guards the `< window` bound in recently_sent() against a >=/off-by-one regression that would swallow every later real alert and warn the miner only once though the rig is still down. selftest 15/15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safe-additive KAT. Completes the throttle-honesty triad:
Without #8c, a single stale alert could masquerade as permanent coverage of an ongoing outage: the miner is warned once and never again though the rig is still down. Guards the
< windowbound in recently_sent() against a >=/off-by-one regression.selftest 15/15 green. Web-only / scripts-only, non-consensus.