dash(launcher): --listen/--addnode/--connect sharechain peering CLI contract - #575
Merged
Conversation
…ontract main_dash gains the pool-to-pool peering argv the G2 dual-pool ratchet LIVE rows (C1-C4) invoke, matching main_btc (--sharechain-port + bootstrap): --listen [HOST:]PORT sharechain bind (default = SSOT 8999/18999) --addnode HOST:PORT persistent outbound peer (repeatable) --connect HOST:PORT connect-only peer; listen + discovery suppressed (repeatable) Lands the argv CONTRACT + HOST:PORT validation (malformed => rc 2) and a run-loop topology report. Honest scope: the LIVE bind/dial rides DASHs sharechain pool Node (node.hpp/peer/messages/share_tracker, the pool::NodeBridge analog of btc::Node) which is NOT yet on master -- next S8 leaf; this surface wires straight into it. dash-fenced (main_dash only); no shared-base / other-coin edit; dashd-RPC fallback untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
main_dash gains the pool-to-pool peering argv the G2 dual-pool ratchet LIVE rows (C1-C4) invoke, matching main_btc (
--sharechain-port+ bootstrap):--listen [HOST:]PORT— sharechain bind (default = SSOT 8999 main / 18999 test)--addnode HOST:PORT— persistent outbound peer (repeatable)--connect HOST:PORT— connect-only peer; listen + discovery suppressed (repeatable)Lands the argv contract + HOST:PORT validation (malformed => rc 2) + a run-loop topology report.
Scope (honest — CLI surface, not yet live peering)
Clears gate (b)’s CLI-surface half. The LIVE bind/dial rides DASH’s sharechain pool Node (
node.hpp/peer/messages/share_tracker— thepool::NodeBridgeanalog ofbtc::Node/dgb::Node), which is NOT yet on master = the next S8 leaf. This surface wires straight into it.Fencing
dash-fenced (main_dash.cpp only); no shared-base / other-coin edit; dashd-RPC fallback untouched. GPG-signed.
Evidence (Linux x86_64)
--selftest3/3 consensus checks green (no regression)--addnode bogus/--listen 99999=> rc 2Held for integrator verify → operator tap. No self-merge.