bch: wire --pool external BCHN-RPC fallback endpoint from --rpc-conf - #610
Merged
Conversation
run_pool builds config by hand (no YAML load), leaving config.coin()->m_rpc unset. The embedded daemon is the primary work source, but coin::Node:: init_rpc still binds the external BCHN-RPC as the v36 external_fallback sink and eager getwork prime; an unset endpoint yielded "Connection refused", so the --pool run had only the embedded leg with no live external fallback. Thread the existing --rpc-conf flag (already parsed but ignored by --pool) into run_pool and load rpcuser/rpcpassword/rpcport via the existing load_rpc_conf helper, setting config.coin()->m_rpc.address + userpass. The external RPC fallback + submitblock leg now reach the operator node (verified against an isolated testnet4 BCHN on :28332: CoindRPC connected). PER-COIN ISOLATION: src/impl/bch entrypoint only. p2pool-merged-v36 surface: NONE (run-loop RPC endpoint wiring; no share/PPLNS/coinbase/PoW bytes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Threads the existing --rpc-conf flag into the --pool run-loop so the embedded daemon external BCHN-RPC fallback (+ submitblock leg + eager getwork prime) reaches the operator node instead of an unset endpoint (Connection refused).
Fenced: src/c2pool/main_bch.cpp run_pool only (+23/-3). PER-COIN ISOLATION: src/impl/bch entrypoint. p2pool-merged-v36 surface: NONE.
Verified against an isolated testnet4 BCHN substrate (chain=test4 at tip h312817) on :28332 -- CoindRPC connected (previously Connection refused). Build green.
NOTE: this is the RPC leg of the testnet4 crossing. The embedded HeaderChain P2P leg still EOF-drops because --testnet emits testnet3 magic (f4e5f3f4) vs test4; a --testnet4 magic path is the follow-on slice for stratum-jobs-off-tip.
Surface-for-tap: NO self-merge -- integrator merges on operator push approval.