ci(build): do not cancel-in-progress on push runs - #637
Merged
Conversation
The concurrency group is per-ref (github.workflow-github.ref). On master, every merge is a push to the same ref, so back-to-back merges share one group and cancel-in-progress kills the prior merge in-flight rollup before it verifies green. #626 (concurrency-groups) bit the #617 web-static lane exactly this way: the last completed master CI run (28692641464) shows Web-static verify=cancelled while Windows x86_64=success. Gate cancel-in-progress to non-push events only. PR churn (rapid re-pushes to a PR ref) still de-dupes and sheds the shared-pool OOM load that #626 targeted; master/release/tag runs always run to completion so a merged SHA is actually verified. Fenced to the concurrency block, no job changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The build.yml concurrency group is per-ref (
github.workflow-github.ref). On master every merge is a push to the same ref, so back-to-back merges share one group andcancel-in-progress: truecancels the prior merge in-flight rollup before it verifies green.Evidence: last completed master CI run 28692641464 (#626 merge) shows Web-static verify = cancelled while Windows x86_64 = success — the newer merge cancelled the older one mid-flight. This is #626 concurrency biting master, the watch-item flagged when #626 landed.
Fix
Gate cancel-in-progress to non-push events:
Fenced to the concurrency block; no job or runner changes. Single-file, CI-infra.