Skip to content

bch: gate work-source donation script on v36 (P2SH) — close recompute/GENTX residual #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frstrtr wants to merge 1 commit into from
Closed

bch: gate work-source donation script on v36 (P2SH) — close recompute/GENTX residual #653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/impl/bch/pool_entrypoint.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,16 @@ inline void standup_pool_run(boost::asio::io_context& ioc,
work_source->set_best_share_hash_fn(
[&node]() -> uint256 { return node.best_share_hash(); });

// Initial donation matches the cold-start create version (35 -> P2PK). A
// ratchet-driven refresh to the COMBINED P2SH on v36 activation is the same
// follow-up slice as pplns_fn/ref_hash_fn.
work_source->set_donation_script(PoolConfig::get_donation_script(35));
// Work-source donation MUST match the authored share version. Shares are
// authored v36-native (result.share_version = 36 above, verify-preimage
// fix), and generate_share_transaction rebuilds the coinbase donation with
// get_donation_script(36) -> COMBINED P2SH. Serving the v35 P2PK here made
// the miner-hashed template coinbase carry a 67-byte P2PK donation while
// verify rebuilt a 23-byte P2SH donation -> the donation output diverged at
// byte offset 104 on every non-genesis share -> 100% recompute/GENTX
// mismatch. Gate on 36 to match. (Dynamic ratchet-tracking generalises this
// once the staged v35+v36 dual-pool migration lands.)
work_source->set_donation_script(PoolConfig::get_donation_script(36));

// -- ref_hash_fn: peer-verifiable share commitment (G2 conform) --------
// Without this the local-author coinbase carries NO p2pool OP_RETURN
Expand Down
Loading