dash(s8-p2p.3): bind real sharechain P2P listener in --run - #659
Merged
Conversation
node.cpp reception bodies landed (#656/#657), so dash::Node (NodeBridge<NodeImpl,Legacy,Actual>) is fully linkable. Link the dash OBJECT lib into c2pool-dash and replace the NOTE-only report_peering stub with a real bind: --run now constructs dash::Config + dash::Node and calls core::Server::listen(port), opening an actual sharechain P2P socket (default 8999/testnet 18999, --listen [HOST:]PORT override; --connect suppresses inbound). PREFIX kept as a per-coin isolation primitive from the frstrtr/p2pool-dash oracle constants. Inbound reception (version handshake + #646 min-proto gate) is live via node.cpp. Active outbound dialing of addnode/connect seeds rides the download/outbound slice (dash::NodeImpl has no start_outbound_connections yet); seeds are registered in the addr store. dashd-RPC submitblock fallback untouched. Verified: c2pool-dash --run --testnet --listen 29777 -> ss shows LISTEN 0.0.0.0:29777 held by c2pool-dash; Factory started for port 29777.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S8-p2p.3 — listener bind
node.cpp reception bodies landed (#656/#657), so
dash::Node(NodeBridge<NodeImpl,Legacy,Actual>) is now fully linkable. This slice makesc2pool-dash --runopen a real sharechain P2P socket instead of only echoing the topology.What changed
dashOBJECT lib (protocol_actual/legacy + node.cpp) intoc2pool-dash; refresh the stale comment that claimed node.cpp does not exist.run_node: replace the NOTE-onlyreport_peeringstub with a real bind — constructdash::Config+dash::Node, callcore::Server::listen(port). Default port 8999 (testnet 18999),--listen [HOST:]PORToverride,--connectsuppresses inbound.Scope / honesty
dash::NodeImplhas nostart_outbound_connectionsyet (rides the download/outbound slice).--addnode/--connecttargets are registered in the addr store but not actively dialed. Labelled in code + logs — not a silent stub.dashisc2pool-dash; ltc/btc/doge/dgb build+ctest surfaces untouched.Verification (Linux x86_64)
cmake --build . --target dash— object lib builds clean.cmake --build . --target c2pool-dash— links clean../c2pool-dash --run --testnet --listen 29777→ssshowsLISTEN 0.0.0.0:29777held by c2pool-dash; log:Factory started for port: 29777.Stacks on master @fa4eef43. Requesting integrator diff + full-CI verify (oracle + Linux ctest, no false-green).