ltc: add c2pool-ltc release entrypoint (main_ltc.cpp) — close the hollow-green skip - #669
Merged
Merged
Conversation
…-> main_ltc.cpp) The coin-matrix / release presence gate keys on src/c2pool/main_ltc.cpp (the real entrypoint, not src/impl/ltc/main -- see PR #66). LTC had no such file, so the ltc cell hit the presence gate, hollow-green-skipped, and produced NO pkg-*-ltc artifact -- a tagged release would ship an LTC package with no LTC binary. Fix, mirroring the sibling coins (btc/dgb/bch/dash): - git mv src/c2pool/c2pool_refactored.cpp -> src/c2pool/main_ltc.cpp (100%% rename; c2pool_refactored.cpp WAS the LTC-native main). Repoint the existing c2pool and c2pool_enhanced targets to main_ltc.cpp. - add_executable(c2pool-ltc main_ltc.cpp) with the c2pool_enhanced link set verbatim (LTC is the reference coin). DOGE aux rides via c2pool_merged_mining -- always compiled in, NO -DAUX_DOGE flag. - WIN32/MSVC parity (ws2_32/bigobj/8MB stack) so the Windows release cell links. - verify_archival.sh: repoint the active-implementation checks to main_ltc.cpp (standalone helper, not CI-wired) so it stops flagging a false MISSING (CRITICAL ERROR). Presence gate other half (src/impl/ltc/) already present. Build target name c2pool-ltc and binary path src/c2pool/c2pool-ltc match release.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release / coin-matrix presence gate is
[ -f src/c2pool/main_ltc.cpp ] && [ -d src/impl/ltc ](release.yml:69; the real entrypoint, notsrc/impl/ltc/main— see #66). LTC had nosrc/c2pool/main_ltc.cpp, so the ltc cell failed the gate, hollow-green-skipped to fake success, and uploaded nopkg-*-ltcartifact. Tagging now would publish an "LTC release" with no LTC binary. This closes that gap.What
Mirrors the sibling coins (btc/dgb/bch/dash):
git mv src/c2pool/c2pool_refactored.cpp -> src/c2pool/main_ltc.cpp(100%% rename —c2pool_refactored.cppwas the LTC-native main). Existingc2poolandc2pool_enhancedtargets repointed tomain_ltc.cpp.add_executable(c2pool-ltc main_ltc.cpp)with thec2pool_enhancedlink set verbatim (LTC is the reference coin — same proven graph). DOGE aux rides viac2pool_merged_mining, always compiled in, NO-DAUX_DOGE.main_ltc.cpp(standalone helper, not CI-wired — was emitting a falseMISSING (CRITICAL ERROR)).Gate status
src/c2pool/main_ltc.cpp✅ (this PR) +src/impl/ltc/✅ (already present) → gate now returns exists=1, ltc cell builds a real artifact instead of skipping.c2pool-ltcand binary pathsrc/c2pool/c2pool-ltcmatch release.yml:131/136.Left intentionally untouched
c2pool_refactored.cpp(node.hpp, main_btc.cpp, etc.) — non-build, line numbers would drift; not in scope.CMakeLists_enhanced.txt— dormant, notadd_subdirectory-included anywhere (references archivedc2pool.cpp).Base master @ b21596f. Commit GPG-signed. Requesting review + merge from integrator; do not tag until the release run shows a non-empty pkg-*-ltc.