release.yml: wire DMG + Inno Setup installers; per-coin/off-tag rebuild inputs - #671
Merged
Conversation
…age jobs The release matrix produced only .tar.gz/.zip archives; the installer/ DMG and Inno Setup scripts were present but un-invoked, so v0.2.0 shipped without the .dmg / setup.exe the alphas had. Wire both per-coin: - macos-universal job: build <coin>-<version>-macos-universal.dmg from the already-lipo-merged universal package via installer/macos/create-dmg.sh (new --staged mode: wrap a prepared tree, no re-copy/dylib rewrite). - windows job: build <coin>-<version>-windows-x86_64-setup.exe via ISCC over the staged package dir; vc_redist located at build time. - Parameterize create-dmg.sh (--name/--version/--arch) and c2pool-setup.iss (#ifndef guards on name/version/exe/output) for the c2pool-<coin> layout; alpha positional/default behaviour preserved.
…r rebuilds Dispatching from a branch resolved version to 0.0.0-<sha>, so package names would not match a released tag. The optional version input lets a scoped rebuild off the released commit emit the exact tag naming (e.g. c2pool-ltc-0.2.0-macos-universal.dmg) without re-cutting the tag.
…ne coin Lets a scoped installer rebuild target a single coin (e.g. ltc) instead of the full five-coin matrix, avoiding needless hosted macOS/Windows runner minutes. Blank input keeps the full matrix on tag pushes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the macOS DMG and Windows Inno Setup installers into the tag-triggered release matrix and makes asset names track the c2pool-/version layout.
What lands:
Resolves the 4 package-spec deltas flagged by ltc-doge-production-steward (VERSION bump/override, c2pool-ltc-* prefix, macOS universal via lipo, Windows exe name). All three commits GPG-signed. Gated on operator push-approval.