packaging: auto-detect per-coin binary in bundled launchers - #684
Merged
Conversation
release.yml packages the node as c2pool-<coin> (c2pool-ltc, ...), but start.sh/start.bat launched a hard-coded ./c2pool / c2pool.exe that does not exist in the tarball, breaking the documented first-run for every coin package. Resolve the binary by c2pool-* glob (single binary per package) with a plain-c2pool fallback for source builds, and derive the banner from the binary name so it cannot go stale (was v0.1.1-alpha).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release.yml packages the node per-coin as
c2pool-<coin>(c2pool-ltc,c2pool-btc, ...), but the bundled launchers hard-coded a binary that is not in the tarball:start.shlaunched./c2pool-> No such filestart.batlaunched%DIR%c2pool.exe-> same on Windowsstart.shbanner was stale (v0.1.1-alpha, release isv0.2.0)Since README says "extract and run ./start.sh", a fresh v0.2.0 user hit this immediately.
Fix — auto-detect (issue option 3)
The same
start.sh/start.batis copied into every coin package by the shared matrix step, so hard-coding any single coin name would only fix one of five packages. This resolves the binary byc2pool-*glob (each package contains exactly one), with a plain-c2poolfallback for source builds:start.sh:find "$DIR" -maxdepth 1 -type f -name "c2pool-*" -perm -u+xstart.bat:for %%f in ("%DIR%c2pool-*.exe") do set BIN=%%fNo release.yml change needed — the per-coin rename stays. Docs reconciliation is integrator PR #682 (docs-only).
Not self-merging — awaiting operator push-approval per standing rule.