btc(nmc PR-1): link nmc_coin into c2pool-btc target - #692
Merged
Conversation
Wire the embedded NMC coin object library into the packaged per-coin c2pool-btc binary so the shipped BTC package can carry Namecoin embedded merged-mining. Link-only slice: supplies nmc::coin Transaction ctors; the MM-manager host activation + aux commitment into the coinbase build land in the following slice on main_btc. No behavior change on its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-1 of 3 wiring embedded Namecoin merged-mining into the packaged c2pool-btc binary (the per-coin release.yml artifact, main_btc.cpp), so a shipped BTC v0.2.x package can carry NMC embedded MM. Today NMC host activation lives only in main_ltc.cpp (the multi-net binary), which release.yml does not package as the BTC artifact.
This slice (link-only, no behavior change)
Adds
nmc_cointo the c2pool-btctarget_link_librariesblock insrc/c2pool/CMakeLists.txt(1 line). Supplies the nmc::coin out-of-line Transaction/MutableTransaction ctors that the aux-commitment path will call. No call sites yet, so the linker drops the unreferenced objects — the value here is proving nmc_coin is link-compatible with c2pool-btc's toolchain/flags (no ODR/symbol conflict).Verify
Clean from-scratch build on workstation:
[100%] Built target c2pool-btc, exit 0, no errors. Binary 8.1 MB.Follows (separate slices, each off master)
Base off master per slice rule. No self-merge — for integrator review + operator tap.