Skip to content

cmake: set /EHsc for MSVC — fixes boost::throw_exception LNK2019 (all Windows release builds) #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frstrtr merged 1 commit into from
Jul 15, 2026
Merged

cmake: set /EHsc for MSVC — fixes boost::throw_exception LNK2019 (all Windows release builds) #707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ endif()
if(MSVC)
# Suppress common MSVC warnings for POSIX names and unsafe CRT functions
add_compile_definitions(_CRT_SECURE_NO_WARNINGS _WINSOCK_DEPRECATED_NO_WARNINGS)
# Enable C++ unwind semantics (/EHsc). Boost headers (asio, log, signals2)
# reference the inline boost::throw_exception, which links as an unresolved
# external (LNK2019) unless exceptions are enabled. The pinned Conan MSVC
# toolchain does not guarantee CMake's default /EHsc, so set it explicitly
# for every MSVC target — the coin binaries and the CI boost_sentinel alike.
add_compile_options(/EHsc)
endif()

# Handle CMake 3.30+ policy for FindBoost removal
Expand Down
Loading