Skip to content

release.yml: resilient Windows setup.exe step (skip when Inno Setup unavailable, always ship .zip) #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frstrtr merged 1 commit into from
Jul 15, 2026
Merged

release.yml: resilient Windows setup.exe step (skip when Inno Setup unavailable, always ship .zip) #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,14 +577,28 @@ jobs:
name: pkg-windows-${{ matrix.coin }}
path: c2pool-*-windows-x86_64.zip

# Installer is a NICE-TO-HAVE: the portable .zip (uploaded above) is the
# must-have deliverable. If Inno Setup is unavailable on the runner (e.g.
# VM217 where choco cannot write C:\ProgramData\chocolatey\lib-bad), warn
# and skip so the job still succeeds and the .zip ships. Durable fix is a
# persistent Inno Setup 6 install on the runner (ISCC on PATH).
- name: Build setup.exe installer (Inno Setup)
if: steps.presence.outputs.exists == '1'
shell: cmd
continue-on-error: true
run: |
choco install innosetup -y --no-progress
set "ISCC=C:\Program Files (x86)\Inno Setup 6\ISCC.exe"
if not exist "%ISCC%" (
echo Inno Setup not found; attempting install via chocolatey...
choco install innosetup -y --no-progress || echo WARNING: choco install innosetup failed
)
if not exist "%ISCC%" (
echo ::warning::Inno Setup unavailable on this runner; skipping setup.exe. Portable .zip already uploaded.
exit /b 0
)
set "PKG=c2pool-${{ matrix.coin }}-${{ steps.ver.outputs.version }}-windows-x86_64"
for /f "delims=" %%i in ('powershell -NoProfile -Command "(Get-ChildItem -Path 'C:\Program Files\Microsoft Visual Studio\2022' -Recurse -Filter vc_redist.x64.exe -ErrorAction SilentlyContinue | Select-Object -First 1).FullName"') do set "VCREDIST=%%i"
"C:\Program Files (x86)\Inno Setup 6\ISCC.exe" installer\windows\c2pool-setup.iss ^
"%ISCC%" installer\windows\c2pool-setup.iss ^
/DPACKAGE_DIR="%CD%\%PKG%" ^
/DVCREDIST_PATH="%VCREDIST%" ^
/DMyAppName=c2pool-${{ matrix.coin }} ^
Expand All @@ -599,6 +613,7 @@ jobs:
with:
name: pkg-windows-setup-${{ matrix.coin }}
path: c2pool-*-windows-x86_64-setup.exe
if-no-files-found: ignore

# ════════════════════════════════════════════════════════════════════════════
# Aggregate: single SHA256SUMS over every produced package; on tags,
Expand Down
Loading