dash(S8): main_dash --stratum run-path caller — StratumServer <-> DASHWorkSource standup#715
Merged
Merged
Conversation
…HWorkSource standup Closes the S8 "no run-path caller" gap: the DASHWorkSource IWorkSource seam (#706, 4a skeleton + 4b bodies) and the subscribe->notify->submit KATs (#630-634) had no production caller — a real main that constructs the work source and binds a core::StratumServer to it. This is that caller. - main_dash.cpp: --stratum [HOST:]PORT argv (SSOT parse_listen); threaded into run_node; node_coin_state -> DASHWorkSource -> StratumServer standup; won-block dispatch via the EXISTING dashd-RPC submitblock arm (rpc->submit_block_hex) — embedded P2P relay leg stays S8; UNARMED path logs loudly, never a silent drop. Destruction order: stratum_server declared before the work source it references; explicit reset() after ioc.run(). dashd-RPC fallback RETAINED (never removed). - src/c2pool/CMakeLists.txt: link dash_stratum into c2pool-dash (the 4b work_source.cpp bodies) — without it the executable failed to link (undefined DASHWorkSource ctor). Build-glue for the caller. Verified Linux x86_64: c2pool-dash links clean; --run --stratum 127.0.0.1:13333 stands up the acceptor (DASHWorkSource constructed, StratumServer bound, clean stop). subscribe->notify->submit binding is KAT-covered at the work_source seam (#630-634). No other-coin / shared- base edit; per-coin isolation held.
frstrtr
force-pushed
the
dash/s8-main-stratum-standup
branch
from
July 16, 2026 11:39
86020b7 to
f67ef1b
Compare
frstrtr
marked this pull request as ready for review
July 16, 2026 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The production run-path caller for the DASHWorkSource IWorkSource seam. #706 (4a skeleton + 4b bodies) and the subscribe->notify->submit KATs (#630-634) built the work source and its binding but had no caller — a real
mainthat constructs it and binds acore::StratumServer. Closes the S8 "no run-path caller" gap.Change (2 files, +110)
--stratum [HOST:]PORTargv (SSOTparse_listen) threaded intorun_node;node_coin_state -> DASHWorkSource -> StratumServerstandup; won-block dispatch via the existing dashd-RPC submitblock arm (embedded P2P relay leg stays S8; UNARMED path logs loudly, never a silent drop); safe destruction ordering.dash_stratumintoc2pool-dash— without it the exe failed to link (undefined DASHWorkSource ctor).Verified (Linux x86_64)
c2pool-dashlinks clean;--run --testnet --stratum 127.0.0.1:13333stands up the acceptor (DASHWorkSource constructed, StratumServer bound, clean stop on shutdown). subscribe->notify->submit is KAT-covered at the work_source seam (#630-634).Posture
dash/s8-stratum-work-source); DRAFT / held open until dash(S8): DASHWorkSource concrete IWorkSource -- 4b .cpp bodies + dash_stratum OBJECT lib + KAT #706 lands, then retarget to master.