btc(msvc): disambiguate second HexStr C2668 at coin/node.hpp:131#717
Merged
Conversation
MSVC C2668: HexStr(std::vector<unsigned char>) is viable for all three Span overloads (uint8_t/char/std::byte). This is the SAME ambiguity #711 fixed in share_tracker.hpp, at a second call site the block-submit fallback path uses. Feed the exact Span<const uint8_t> the intended overload wants, matching the #711 pattern byte-for-byte. Swept all HexStr call sites reachable from the MSVC btc build: the only other bare-container sites (config_coin prefix, config_pool m_prefix) are std::vector<std::byte>, which match a single overload and are already unambiguous. No third site remains.
frstrtr
added
the
SAFE-COSMETIC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the sole remaining v0.2.1 Windows build failure (run 29467003679):
node.hpp(131,40): C2668 ambiguous HexStr.Same MSVC ambiguity #711 fixed in share_tracker.hpp, at a second call site (block-submit RPC fallback).
std::vector<unsigned char>is viable for all three Span overloads; feed the exactSpan<const uint8_t>— byte-identical to the #711 pattern.Swept every HexStr site reachable from the MSVC btc build: the only other bare-container sites (config_coin
prefix, config_poolm_prefix) arestd::vector<std::byte>, which match a single overload and are already unambiguous. No third site remains.