Skip to content

btc(msvc): disambiguate second HexStr C2668 at coin/node.hpp:131 #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frstrtr merged 1 commit into from
Jul 16, 2026
Merged

btc(msvc): disambiguate second HexStr C2668 at coin/node.hpp:131 #717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/impl/btc/coin/node.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,11 @@ class Node : public btc::interfaces::Node
{
if (!m_rpc)
return false;
return m_rpc->submit_block_hex(HexStr(block_bytes), /*ignore_failure=*/true);
// MSVC: disambiguate HexStr overload (std::vector<unsigned char> is viable
// for all span overloads). Feed the exact byte span the uint8_t overload wants.
return m_rpc->submit_block_hex(
HexStr(Span<const uint8_t>(block_bytes.data(), block_bytes.size())),
/*ignore_failure=*/true);
}

/// Broadcast a WON block with FALLBACK semantics: P2P relay is primary,
Expand Down
Loading