ci(release): fix false-red btc-Windows --help smoke (PowerShell pipe truncation)#719
Merged
Merged
Conversation
The Windows smoke step piped a native command straight into Select-Object -First 5. --help writes usage to stderr; the -First 5 truncation closes the pipe early, so PowerShell raises a NativeCommandError and the step exits 1 even though the binary printed correct usage (build succeeded, link succeeded). Buffer the output into a variable first (exe runs to completion, no broken pipe), then Select-Object on the array, and exit 0 to match the Linux/macOS lanes, which already use || true. Smoke is a liveness check, not a gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run 29493641642 (v0.2.1 re-dispatch off master 1737f37) shows btc package (Windows x86_64) red at the Smoke test (--help) step — but the binary is fine: build and link succeeded, and the log shows correct usage output (
Usage: c2pool-b...coind HOST:PORT).Root cause: the step piped
c2pool-<coin>.exe --help 2>&1 | Select-Object -First 5.--helpwrites usage to stderr;Select-Object -First 5truncates and closes the pipe early, so PowerShell surfaces aNativeCommandErrorand the step exits 1. The Linux/macOS smoke lanes already tolerate this with|| true; the Windows lane did not.Fix: buffer the output into
$outfirst (exe runs to completion, no broken pipe), Select-Object on the array, andexit 0. Smoke is a liveness check, not a gate.Unblocks the v0.2.1 release consolidation (all 5 Windows lanes were passing except this false red on btc). No self-merge — integrator gate.