Skip to content

bch: correct 2 stale broadcaster comments -- reconstruction has landed (#744) #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frstrtr merged 1 commit into from
Jul 21, 2026
Merged

bch: correct 2 stale broadcaster comments -- reconstruction has landed (#744) #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/impl/bch/node.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,11 @@ class NodeImpl : public pool::SharechainNode<bch::Config, bch::ShareChain, bch::
// other_txs from m_known_txs via the share transaction_hash_refs over
// parent shares (data.py get_other_tx_hashes / _get_other_txs); returns
// nullopt when not all parent txs are present (== as_block None).
// NOTE: coinbase (gentx) full-body reconstruction (GenerateShareTransaction,
// share_check.hpp:472) is the remaining dependency before this emits a
// complete block; until it lands this returns nullopt -- no partial/
// invalid block is ever broadcast. The other_tx gather seam is here.
// Coinbase (gentx) full-body reconstruction is IMPLEMENTED below via
// generate_share_transaction (the same fn the verify path uses), so this
// emits a COMPLETE wire block on success. nullopt is returned ONLY when not
// all parent txs are present (== as_block None) or the gentx/header build
// fails -- never a partial/invalid block. The other_tx gather seam is here.
std::optional<std::pair<std::vector<unsigned char>, std::string>>
reconstruct_won_block(const uint256& share_hash)
{
Expand Down
11 changes: 7 additions & 4 deletions src/impl/bch/pool_standup.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,13 @@
// run-loop; idempotent (set_block_broadcaster replaces).
//
// The sink being live is NECESSARY but NOT SUFFICIENT to close the gate to
// verified: reconstruct_won_block() still returns nullopt until gentx (coinbase)
// full-body reconstruction lands (share_check.hpp:472) and leg C is exercised
// against VM300 (192.168.86.110:8333). Until then the lambda has a live sink yet
// emits nothing -- the gate stays honestly GAP and no partial block is relayed.
// verified: reconstruct_won_block() now fully reconstructs the block (gentx +
// header + full wire serialization), so on a won share the lambda emits a
// complete block down BOTH broadcast arms. What remains before the gate flips to
// verified is a run-path dual-path soak -- leg C (submitblock RPC) exercised
// against a live BCHN (e.g. VM300, 192.168.86.110:8333) alongside the P2P relay
// arm. Until that soak lands the gate stays honestly GAP on VERIFICATION, not on
// missing code; no partial block is ever relayed (nullopt on incomplete txs).
//
// PER-COIN ISOLATION: src/impl/bch only. Zero p2pool-merged-v36 surface -- block
// dispatch, NOT share/PPLNS/coinbase bytes. BCH = SHA256d standalone parent.
Expand Down
Loading