dash: T1c byte-parity KAT vs live p2pool-dash oracle corpus (share-v16) [do-not-merge] - #821
dash: T1c byte-parity KAT vs live p2pool-dash oracle corpus (share-v16) [do-not-merge]#821frstrtr wants to merge 1 commit into
Conversation
Close the T1c serialization-parity gap the 2026-07-21 join-lane audit
flagged: test_dash_conformance.cpp only exercised synthetic/out-of-band
vectors, with no byte-parity test against a real p2pool-dash node.
Adds:
- test/data/dash_oracle_corpus.hpp: 29 distinct canonical shares captured
off a controlled p2pool-dash node JOINED to the live public sharechain
(share-v16 / min-proto-1700), each raw wire-entry cross-validated
byte-identical across 4 independent peers, deduped by share_hash.
- test/test_dash_oracle_byte_parity.cpp: round-trips every canonical
SHARE_RAW through the production load_share -> DashFormatter::Read ->
DashFormatter::Write path and asserts serialize(parse(raw)) == raw
(the exact condition for a relayed share to VERIFY_PASS on the fork),
plus semantic cross-checks (prev_hash / donation / new_tx_count /
pubkey_hash -> payout_script) against the fork's SHARE_RECV fields.
Result: 30/30 pass. c2pool's DASH v16 layout already byte-matches the
canonical fork; no serialization divergence found. Promotes the real
captured-corpus KAT the conformance suite was missing.
e9f3665 to
61e12b5
Compare
|
This should go green on a rebase now — #918 landed the mechanism fix. This PR has been red since 07-25 for a reason that had nothing to do with its content. The two failing legs report: "Not Run" was never a test failure — it was #918 (merged Verified: this branch was last updated 2026-07-25T11:28Z and does not contain ActionRebase onto master and re-run. If Why this PR matters more than its red status suggestsIt carries the T1c corpus: 29 canonical shares captured off a live p2pool-dash node joined to the public sharechain, each cross-validated byte-identical across 4 independent peers, asserting That is our only real evidence of wire-format parity with canonical p2pool — and it has been sitting unmerged and unrun for two days over a CI registration mechanism. Landing it converts byte-parity from a local claim into a CI-enforced gate. Worth stating plainly: I predicted this would go green the moment #918 merged. It did not, because CI results do not retroactively apply to a branch that predates the fix. The rebase is the missing step. |
1 participant
T1c byte-parity — the last gate before ★M1 JOIN
Closes the serialization-parity gap the 2026-07-21 join-lane audit flagged:
test_dash_conformance.cpponly exercised synthetic / out-of-band vectors —there was no byte-parity test against a real p2pool-dash node. This adds one.
What
test/data/dash_oracle_corpus.hpp— 29 distinct canonical shares capturedoff a controlled p2pool-dash node JOINED to the live public sharechain
(share-v16 / min-proto-1700) via the oracle-gate on VM210. Each raw wire entry
[VarInt type=16][VarStr contents]was cross-validated byte-identical across4 independent peers, deduped by
share_hash.test/test_dash_oracle_byte_parity.cpp— for every canonicalSHARE_RAW:round-trips it through the production
load_share→DashFormatter::Read→DashFormatter::Writepath and assertsserialize(parse(raw)) == raw— theexact condition for a c2pool-relayed share to
VERIFY_PASSon the fork — plussemantic cross-checks (
prev_hash/donation/new_tx_count/pubkey_hash → payout_script) against the fork's independently-parsedSHARE_RECVfields.Result
canonical p2pool-dash fork — zero serialization divergences found. The gap
was test coverage (synthetic vectors), now closed with the real captured corpus.
Live corroboration (out-of-band, not in this PR)
A
c2pool-dash --run --connect <oracle>:8999node was accepted as a peer by thecanonical fork (
Incoming connection ... p2pool version: 1700 'c2pool', peers4→5), downloaded the full live sharechain and parsed every share with 0 parse
failures / 0 VERIFY_FAIL, and disconnected cleanly — 0 VERIFY_DIFF / 0 NOBAN
logged by the oracle. The offline round-trip KAT here pins that parity as a
repeatable gate with no live dependency.
Not yet exercised
The
c2pool mints a fresh share → oracle byte-VERIFY_PASSes itleg needs astratum miner + coin RPC on the joined chain (the mint-and-relay step); the
connect-only download node above does not produce shares. Serialization parity
(what determines the byte-diff outcome) is proven both offline and by clean
full-chain parse.
do-not-merge — integrator reviews + merges.