PR-0: bitcoin_family shared foundation (re-land off dash/pr0-foundation-clean @ edaf1dbf) - #83
Merged
Merged
Conversation
…ddress_validator) Net shared-base delta over master collapsed from the 118-commit foundation: 5 files / +234 -29. socket.hpp + base_p2p_messages.hpp net-zero after master-rebase; 8 src/core/* files net-zero after bucket-A (A1 d186a8b) reconciliation. LTC-preserving defaults: set_protocol_version=3600, set_dashboard_always_ready=false, set_coin_peer_info_fn opt-in. Refs PR #43 umbrella.
ltc-doge live-diff (NEEDS-CHANGE) found three LTC/DOGE-affecting deltas
that rode along the rest_local_stats/update_stat_log refactor, outside the
LTC-preserving-defaults framing:
D1 rest_local_stats: block_value_payments regressed from block_value to 0
for LTC and DOGE. Gate payment_amount to DASH; LTC/DOGE keep block_value.
D2 rest_version_signaling: returned {} for DOGE (v36, previously populated).
Guard now admits LITECOIN and DOGECOIN, excludes only non-v36 chains.
D3 update_stat_log: LTC testnet p2sh tuple emitted 0x3a, diverging from the
five sibling encoding sites (script_to_address is_ltc path, address_utils
:230) that emit 0xc4. Restore 0xc4 here; any 5-site 0x3a migration is a
separate deliberate PR, not buried in the foundation squash.
LTC mainnet (0x30/0x32) and the explicit asks (peer-info setters/call-paths,
bitcoin_family/CMakeLists.txt inert) remain byte-for-byte preserved.
Owner
Author
|
ltc-doge-production-steward verdict: APPROVE (operator redirect "ask-ltc-doge", exceptional shared-base path) Head edaf1db is the identical SHA I signed FLIP-TO-PRESERVE for PR-0 (#65) on 06-04. Re-audited the full 5-file diff for LTC/DOGE preservation:
CI note for the record: latest re-run at edaf1db (2026-06-12 01:02Z) is fully green — Linux x86_64, ASan+UBSan, all coin smokes (ltc/doge/dash/btc/bch/dgb), CodeQL, AND macOS arm64 + Windows x86_64. The 2 failures visible in the rollup are the STALE 06-04 runs (macOS/Windows), superseded green by the 06-12 re-run on this same SHA — not a live defect. Merge is operator-gated; integrator executes. |
This was referenced Jun 18, 2026
frstrtr
added a commit
that referenced
this pull request
Jun 25, 2026
Fresh-branch re-cut of the broadcaster_full keystone onto current master (supersedes #456, whose stale multi-coin base would revert landed btc/dgb/web work on merge). Dash-lane-only: embedded-P2P + dashd submitblock dual-arm won-block broadcaster, 7/7 KATs. src/impl/dash/broadcaster_full.hpp — dual-arm keystone test/test_dash_broadcaster_full.cpp — 7/7 won-block KATs test/CMakeLists.txt — test target registration .github/workflows/build.yml — CI allowlist (test_dash_broadcaster_full)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opens the PR-0 foundation for landing. Prior PR #65 records a merge (c9c6d77, 2026-06-04) but none of its content is present in current master — both 4d9b57d (foundation) and edaf1db (delta-confinement fixup) are absent from master HEAD. This PR re-lands the branch tip so the work tracked since #65 has an open PR again.
Scope (5 files, +234/-29):
Carries the ltc-doge NEEDS-CHANGE resolution: edaf1db confines the 3 stat-refactor deltas (D1 block_value_payments, D2 DOGE version-signaling, D3 LTC-testnet 0xc4) to DASH, preserving LTC/DOGE behavior.
CI on edaf1db: Linux x86_64 GREEN, ASan+UBSan GREEN, all coin smokes (ltc/doge/dash/btc) GREEN, CodeQL GREEN. macOS-arm64 + Windows red are the known base-inherited INetwork drift (resolved on dash @ 25fa819; never a live defect for this surface).
Foundation for #83 (dash-spv-embedded full import). Operator-gated merge.