bch(m4): wire CashAddr KAT into CI; fix stale scrypt pow-hash comment - #855
Merged
Conversation
The CashAddr codec + KAT test landed in master (821ec05) but the test was never registered in CMake or the COIN_BCH build lists, so it never ran in CI -- authored-but-unrun false-green, the same class of gap the #156 embedded-body tests closed at test/CMakeLists.txt:179. - register cashaddr_kat_test in BCH_ABLA_TESTS (pure, header-only over coin/cashaddr.hpp); it now runs under ctest -R ^bch_ on both the COIN_BCH Release and ASan/UBSan legs. - add bch_cashaddr_kat_test to both build.yml COIN_BCH --target lists (Release + sanitizer) so the executable is built before ctest. - rename cashaddr_test.cpp -> cashaddr_kat_test.cpp to match the bch_*_kat_test target convention (asert/coinbase/g2 KATs). - the KAT already asserts encode+decode both directions, BCHN vector parity (PolyMod/version-byte), P2SH32 32-byte roundtrip, and negative cases: corrupt checksum, wrong prefix/hrp, mixed case, bad hash length. share_check.hpp: correct the g_last_pow_hash TLS comments from scrypt to SHA256d -- BCH PoW is SHA256d (stale LTC-port copy). Comment-only. Per-coin isolation held: src/impl/bch/ + build.yml only; no core, no bitcoin_family. No share/sharechain/coinbase/PPLNS change; p2pool-merged-v36 surface unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CashAddr codec + KAT test landed in master (821ec05) but the test was never registered in CMake or the COIN_BCH build lists — it never ran in CI (authored-but-unrun false-green, same class as the #156 embedded-body tests closed at test/CMakeLists.txt:179).
What this does
cashaddr_kat_testinBCH_ABLA_TESTS(pure, header-only overcoin/cashaddr.hpp) — now runs underctest -R ^bch_on both COIN_BCH legs.bch_cashaddr_kat_testto both build.yml COIN_BCH--targetlists (Release + ASan/UBSan) so the executable is built before ctest.cashaddr_test.cpp->cashaddr_kat_test.cppto match thebch_*_kat_testtarget convention.share_check.hpp: correctg_last_pow_hashTLS comments scrypt -> SHA256d (BCH PoW is SHA256d; stale LTC-port copy). Comment-only.Acceptance shape (integrator 2026-07-25)
No share/sharechain/coinbase/PPLNS change; p2pool-merged-v36 surface unchanged. Local: bch_cashaddr_kat_test builds + passes (ctest #241).
Note: a third stale scrypt comment at share_check.hpp:776 is left untouched (outside the approved one-liner scope) — flagging for a follow-up.