Skip to content

bch(m4): wire CashAddr KAT into CI; fix stale scrypt pow-hash comment #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frstrtr merged 1 commit into from
Jul 25, 2026
Merged

bch(m4): wire CashAddr KAT into CI; fix stale scrypt pow-hash comment #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,7 @@ jobs:
bch_coinbase_kat_bytevector_test \
bch_coinbase_author_kat_test \
bch_cashtokens_transparency_test \
bch_cashaddr_kat_test \
bch_block_connector_test bch_block_ordering_test \
bch_utxo_connect_test bch_reorg_connect_test bch_reorg_rerequest_test \
bch_compact_block_connector_test \
Expand Down Expand Up @@ -609,6 +610,7 @@ jobs:
bch_coinbase_kat_bytevector_test \
bch_coinbase_author_kat_test \
bch_cashtokens_transparency_test \
bch_cashaddr_kat_test \
bch_block_connector_test bch_block_ordering_test \
bch_utxo_connect_test bch_reorg_connect_test bch_reorg_rerequest_test \
bch_compact_block_connector_test \
Expand Down
4 changes: 2 additions & 2 deletions src/impl/bch/share_check.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,9 +465,9 @@ inline std::pair<uint256, uint64_t> compute_ref_hash_for_work(const RefHashParam
return {ref_hash, nonce};
}

// Thread-local state from share_init_verify — read by attempt_verify() without re-computing scrypt.
// Thread-local state from share_init_verify — read by attempt_verify() without re-computing the SHA256d PoW.
inline thread_local bool g_last_init_is_block = false;
inline thread_local uint256 g_last_pow_hash; // scrypt hash of the share header
inline thread_local uint256 g_last_pow_hash; // SHA256d hash of the share header

// ============================================================================
// share_init_verify()
Expand Down
1 change: 1 addition & 0 deletions src/impl/bch/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ if(BUILD_TESTING)
g0_canonical_pin_test # G0: canonical-pin vs p2poolBCH @6603b79 baseline + v35->v36 transition rule (pure)
g2_ratchet_gate_kat_test # G2: 60%-by-WORK version-switch accept gate + mint-cannot-outrun-accept (pure)
coinbase_author_kat_test # KAT G2: v36 coinbase output-assembly byte-parity vs p2pool-merged-v36 oracle (pure)
cashaddr_kat_test # M4: CashAddr codec KAT -- encode/decode roundtrip + PolyMod/version-byte parity vs BCHN vectors, prefix/checksum rejection (pure)
)
foreach(t IN LISTS BCH_ABLA_TESTS)
add_executable(bch_${t} ${t}.cpp)
Expand Down
0 src/impl/bch/test/cashaddr_test.cpp → src/impl/bch/test/cashaddr_kat_test.cpp
View file
Open in desktop
File renamed without changes.
Loading