rename DensePPLNSRing -> DensePPLNSWindow (ltc + btc), SAFE-COSMETIC - #87
Merged
Conversation
The class is a std::deque sliding window, not a ring buffer; the name was a misnomer. Pure symbol+comment rename, zero behavior change. The actual ring buffer is the V37 work on v37-dev.
Mirror of the ltc rename for the F1-introduced btc symbol. Pure symbol+comment rename, zero behavior change.
frstrtr
added
the
SAFE-COSMETIC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#85 — pure rename DensePPLNSRing -> DensePPLNSWindow
Rationale (operator-confirmed): the class is a
std::dequesliding window, not a ring buffer. The name was a misnomer; the actual ring buffer is the V37 work (already onv37-dev). Renaming on master removes the confusion before the BTC pillars build on it.Scope: symbol + comments only, zero behavior change.
f5324290.share_tracker/node.cpptouched, no cross-coin entanglement.115e4f00ltc,52491e92btc) so btc-heap-opt's sharechain/v37: MRR roundabout round-buffer base library #84 rebase has a clean btc-only commit.Not in scope (intentional): the member
m_ringand accessorring()keep their names — renaming them would ripple to callers and break the symbol-only / zero-behavior invariant. Flagging for a separate follow-up if desired.Label: SAFE-COSMETIC (auto-merge eligible on CI + preflight + ctest + census green). Merge stays operator-gated.