PR-0 S1: parameterize ltc share path on core::CoinParams - #92
Merged
Conversation
S1 slice of the PR-0 foundation rebase: hand-ported the ltc consumer parameterization onto current master. The dash-spv-embedded source predates master's share_tracker rename (DensePPLNSRing->Window) and the WorkView/CoinNode seam, so this is authored onto master, not cherry-picked. - params.hpp: ltc::make_coin_params factory (new) - node.hpp/node.cpp: m_coin_params member + ctors + coin_params() accessor; rename DensePPLNSRing->DensePPLNSWindow static-member defs to match master - share_check.hpp: PoolConfig statics -> coin_params lookups; 3-arg pubkey_hash_to_address, 2-arg compute_ref_hash_for_work, coin_params-d create_local_share - c2pool_refactored.cpp: pass coin_params() at the 3 ltc call sites; master WorkView/CoinNode seam (set_coin_node) left intact
frstrtr
marked this pull request as ready for review
June 14, 2026 07:06
This was referenced Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-0 Slice S1 — ltc CoinParams parameterization
First of the 5-stage PR-0 foundation slice. Parameterizes the ltc share-validation path on the shared
core::CoinParams(the shared CoinParams core already landed on master); this slice is the ltc residual.Scope / per-coin isolation
Single GPG-signed commit (
133ae6bc). Coin-layer changes are ltc-only — no btc/dash/doge/dgb impl touched. Diff surface:src/impl/ltc/{node.cpp,node.hpp,params.hpp,share_check.hpp,share_tracker.hpp}— ltc parameterizationsrc/c2pool/c2pool_refactored.cpp— shared WorkView consumer seam (5 lines)test/{test_hash_link.cpp,test_threading.cpp}— arity follow-ons for the canonical 60%-switch rule in share_check.hpp step 28 files, +279/-177.
Verification
Linux x86_64: build clean, full ctest 100% passed, 0 failed out of 590 (live tests requiring testnet daemon skipped — VM202 stopped). Touched suites (HashLink / VerifyShareThreading / ComputeShareTarget) all green.
Notes
share_check.hppintentionally does NOT re-addshould_punish_version(removed deliberately upstream); fix is the canonical 60% switch rule.