[WIP] web: collapse triplicated share_version switch in rest_web_currency_info - #935
[WIP] web: collapse triplicated share_version switch in rest_web_currency_info#935frstrtr wants to merge 1 commit into
Conversation
rest_web_currency_info() set result["share_version"] via three byte-for-byte identical switch(m_blockchain) blocks back to back — a merge artifact. The second and third are pure dead code: each rewrites the key the prior block already set to the same value. Collapse to a single block. No behavior change (the emitted JSON is identical); removes 22 lines of redundant code on the web/API layer.
|
Closing as OBSOLETE — superseded by #491 ( This branch was authored 2026-06-23 and is 863 commits behind master. Since then, Master today: This branch: The difference is not cosmetic. Master's own comment states why: during the V35→V36 cross, a node that is still VOTING is producing V35 shares, so reporting a static 36 "would make the explorer misclassify live V35 share cells as V36 — a lie about the crossing state." So resolving this branch's conflict in its own favour would reintroduce exactly the dishonest-surface defect this lane exists to eliminate. The dedup goal is already achieved on master; nothing here remains to land. No action needed on the other CI signals — the |
Refactor: collapse three duplicated share_version switch blocks into one in rest_web_currency_info. Behaviour-preserving. Draft for CI.