[DASH S2] X11 PoW primitive - #98
Merged
Merged
Conversation
Pure single-coin hashing primitive for the DASH S2 PR-0 slice. Diff confined to src/impl/dash/crypto/x11/* plus the hash_x11.hpp wrapper; sole seam is read-only core/uint256.hpp already on master. No ltc/btc/ doge surface. DGW retarget deferred to S3 (header-chain slice). CMake dash_x11 target + KAT ctest wiring follow on this branch.
The S2 X11 KAT executable is registered via gtest_add_tests but the Linux test jobs build an explicit --target list rather than all, so the binary was never compiled and ctest reported both DashX11Kat cases as Not Run. Add test_dash_x11_kat alongside test_doge_chain/test_compact_blocks in both the Linux x86_64 and ASan+UBSan build steps.
frstrtr
marked this pull request as ready for review
June 16, 2026 06:48
Owner
Author
|
Per-coin isolation sign-off — ltc-doge-production-steward (DASH S2): SAFE-ADDITIVE, no cross-coin regression. ✅ (Formal GH Approve blocked — shared push identity can't approve own PR; this comment + email to integrator is the sign-off of record.)
CI green across six coin smokes + Linux x86_64 + ASan/UBSan + Windows + macOS. KAT pins DASH genesis hash end-to-end through the 11-round pipeline. Clear to undraft/merge at operator discretion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S2 slice — X11 PoW hashing primitive (PR-0 foundation decomposition)
Second slice of the dash PR-0 foundation arc (S1 = #92, merged). Adds the X11 proof-of-work hashing primitive for the dash coin module.
Scope
dash_x11static lib: sph reference C (dashcore v0.16.1.1) — BLAKE→BMW→GROESTL→SKEIN→JH→KECCAK→LUFFA→CUBEHASH→SHAVITE→SIMD→ECHO.hash_x11.hppwrapper overcore/uint256.hpp.src/impl/dash/build wiring (add_subdirectory(dash)→crypto).test_dash_x11_kat: hashes the DASH mainnet genesis 80-byte header, asserts the published genesis block hash (pins the full pipeline end-to-end).Safety
SAFE-ADDITIVE. Diff confined to
src/impl/dash/*+ one additive test target. Nothing existing linksdash_x11, so ltc/btc/doge/dgb build + ctest surfaces are untouched. Consumed from S3 (DGW v3 header-chain slice) onward.Verification
DashX11Kat2/2 PASS (run from build/, nonzero test count confirmed).Follow-on slices
DGW v3 retarget → S3; pay → S4; block-replay → S5.
Draft pending CI + ltc-doge review; operator-gated merge.