Skip to content

Commit 8fbe994

Browse files
authored
Merge pull request #335 from fsprojects/repo-assist/eng-package-validation-baseline-a022fc7e9ba547a4
[Repo Assist] eng: enable PackageValidationBaselineVersion=0.4.0 with suppression for known breaking changes
2 parents c6e8975 + 3b2a74d commit 8fbe994

File tree

3 files changed

+27
-1
lines changed

3 files changed

+27
-1
lines changed

release-notes.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ Release notes:
33

44
0.6.0
55
- fixes: async { for item in taskSeq do ... } no longer wraps exceptions in AggregateException, #129
6+
- eng: enable PackageValidationBaselineVersion=0.4.0 to enforce binary compatibility with last published release
67
- adds TaskSeq.compareWith and TaskSeq.compareWithAsync
78
- adds TaskSeq.scan and TaskSeq.scanAsync, #289
89
- adds TaskSeq.pairwise, #289
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
3+
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
4+
<Suppression>
5+
<DiagnosticId>CP0002</DiagnosticId>
6+
<Target>M:FSharp.Control.LowPriority.TaskSeqBuilder#Bind``5(FSharp.Control.TaskSeqBuilder,``0,Microsoft.FSharp.Core.FSharpFunc{``1,Microsoft.FSharp.Core.CompilerServices.ResumableCode{FSharp.Control.TaskSeqStateMachineData{``2},Microsoft.FSharp.Core.Unit}})</Target>
7+
<Left>lib/netstandard2.1/FSharp.Control.TaskSeq.dll</Left>
8+
<Right>lib/netstandard2.1/FSharp.Control.TaskSeq.dll</Right>
9+
<IsBaselineSuppression>true</IsBaselineSuppression>
10+
</Suppression>
11+
<Suppression>
12+
<DiagnosticId>CP0002</DiagnosticId>
13+
<Target>M:FSharp.Control.LowPriority.TaskSeqBuilder#Bind$W``5(Microsoft.FSharp.Core.FSharpFunc{``0,``3},Microsoft.FSharp.Core.FSharpFunc{``3,``1},Microsoft.FSharp.Core.FSharpFunc{``3,System.Boolean},FSharp.Control.TaskSeqBuilder,``0,Microsoft.FSharp.Core.FSharpFunc{``1,Microsoft.FSharp.Core.CompilerServices.ResumableCode{FSharp.Control.TaskSeqStateMachineData{``2},Microsoft.FSharp.Core.Unit}})</Target>
14+
<Left>lib/netstandard2.1/FSharp.Control.TaskSeq.dll</Left>
15+
<Right>lib/netstandard2.1/FSharp.Control.TaskSeq.dll</Right>
16+
<IsBaselineSuppression>true</IsBaselineSuppression>
17+
</Suppression>
18+
<Suppression>
19+
<DiagnosticId>CP0002</DiagnosticId>
20+
<Target>M:FSharp.Control.TaskExtensions.TaskBuilder#For``2(Microsoft.FSharp.Control.TaskBuilder,System.Collections.Generic.IAsyncEnumerable{``0},Microsoft.FSharp.Core.FSharpFunc{``0,Microsoft.FSharp.Core.CompilerServices.ResumableCode{Microsoft.FSharp.Control.TaskStateMachineData{``1},Microsoft.FSharp.Core.Unit}})</Target>
21+
<Left>lib/netstandard2.1/FSharp.Control.TaskSeq.dll</Left>
22+
<Right>lib/netstandard2.1/FSharp.Control.TaskSeq.dll</Right>
23+
<IsBaselineSuppression>true</IsBaselineSuppression>
24+
</Suppression>
25+
</Suppressions>

src/FSharp.Control.TaskSeq/FSharp.Control.TaskSeq.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Generates optimized IL code through resumable state machines, and comes with a c
2828
<!-- Validate package structure and (when PackageValidationBaselineVersion is set) binary compatibility -->
2929
<EnablePackageValidation>true</EnablePackageValidation>
3030
<!-- Set this to the last published version to enforce binary compatibility, e.g. 0.4.0 -->
31-
<!-- <PackageValidationBaselineVersion>0.4.0</PackageValidationBaselineVersion> -->
31+
<PackageValidationBaselineVersion>0.4.0</PackageValidationBaselineVersion>
3232
</PropertyGroup>
3333

3434
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">

0 commit comments

Comments
 (0)