Skip to content

Reinstate Disposal #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abelbraaksma merged 3 commits into from
Jun 2, 2023
Merged

Reinstate Disposal #149

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67c3800
Reinstate Disposal
bartelink May 4, 2023
ab69511
Update release-notes with 0.3.1 for IDispose reinstating
abelbraaksma Jun 2, 2023
6c6af98
Better language in release notes
abelbraaksma Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions release-notes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ Release notes:
- adds AsyncSeq vs TaskSeq comparison chart, #131
- removes release-notes.txt from file dependencies, but keep in the package, #138

0.3.1 (unreleased)
- fixes not calling Dispose for 'use!' and 'use', #157 (fixed by @bartelink)
Comment thread
abelbraaksma marked this conversation as resolved.
Outdated

0.3.0
- internal renames, improved doc comments, signature files for complex types, hide internal-only types, fixes #112.
- adds support for static TaskLike, allowing the same let! and do! overloads that F# task supports, fixes #110.
Expand Down
5 changes: 2 additions & 3 deletions src/FSharp.Control.TaskSeq/TaskSeqBuilder.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,8 @@ type TaskSeqStateMachineData<'T>() =

member data.PushDispose(disposer: unit -> Task) =
if isNull data.disposalStack then
data.disposalStack <- null

//data.disposalStack.Add disposer
data.disposalStack <- ResizeArray()
data.disposalStack.Add disposer

member data.PopDispose() =
if not (isNull data.disposalStack) then
Expand Down