Fix propagating %ERRORLEVEL% in cases where build.cmd fails#243
Merged
abelbraaksma merged 1 commit intomainfrom Mar 17, 2024
Merged
Fix propagating %ERRORLEVEL% in cases where build.cmd fails#243abelbraaksma merged 1 commit intomainfrom
%ERRORLEVEL% in cases where build.cmd fails#243abelbraaksma merged 1 commit intomainfrom
Conversation
abelbraaksma
force-pushed
the
fix-propagating-errorlevel-ghaction
branch
from
91b3147 to
44abf20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was addressed and documented in #105.
However, this change was missed in
publish.yaml, which means we would never see any errors whenbuildis running for a package deploy to nuget,