Removed unnecessary GraphQL types upcasts

Author: xperiandri

src/FSharp.Data.GraphQL.Server.Relay/Connections.fs

@@ -114,8 +114,6 @@ type SliceInfo<'Cursor> =
 
 [<AutoOpen>]
 module Definitions =
-    let inline private nullableOutput (innerDef : #OutputDef<'Val>) : OutputDef<'Val option> =
-        Nullable (innerDef :> OutputDef<'Val>)
 
     /// <summary>
     /// Active pattern that extracts Relay pagination arguments from a GraphQL field context.
@@ -161,13 +159,13 @@ module Definitions =
                 )
                 Define.AsyncField (
                     "startCursor",
-                    nullableOutput StringType,
+                    Nullable StringType,
                     "When paginating backwards, the cursor to continue.",
                     fun _ pageInfo -> pageInfo.StartCursor
                 )
                 Define.AsyncField (
                     "endCursor",
-                    nullableOutput StringType,
+                    Nullable StringType,
                     "When paginating forwards, the cursor to continue.",
                     fun _ pageInfo -> pageInfo.EndCursor
                 )
@@ -227,7 +225,7 @@ module Definitions =
             fields = [
                 Define.AsyncField (
                     "totalCount",
-                    nullableOutput IntType,
+                    Nullable IntType,
                     """A count of the total number of objects in this connection, ignoring pagination. This allows a client to fetch the first five objects by passing \"5\" as the argument to `first`, then fetch the total count so it could display \"5 of 83\", for example. In cases where we employ infinite scrolling or don't have an exact count of entries, this field will return `null`.""",
                     fun _ conn -> conn.TotalCount
                 )
@@ -278,8 +276,6 @@ module Edge =
 
 [<RequireQualifiedAccess>]
 module Connection =
-    let inline private nullableInput (innerDef : #InputDef<'Val>) : InputDef<'Val option> =
-        Nullable (innerDef :> InputDef<'Val>)
 
     /// <summary>
     /// Transforms a <see cref="Connection{T}"/> into a <see cref="Connection{U}"/>
@@ -308,8 +304,8 @@ module Connection =
     /// <seealso cref="backwardArgs"/>
     /// <seealso cref="allArgs"/>
     let forwardArgs =
-        [ Define.Input ("first", nullableInput IntType)
-          Define.Input ("after", nullableInput StringType) ]
+        [ Define.Input ("first", Nullable IntType)
+          Define.Input ("after", Nullable StringType) ]
 
     /// <summary>
     /// Argument definitions for backward pagination ("last" and "before").
@@ -318,8 +314,8 @@ module Connection =
     /// <seealso cref="forwardArgs"/>
     /// <seealso cref="allArgs"/>
     let backwardArgs =
-        [ Define.Input ("last", nullableInput IntType)
-          Define.Input ("before", nullableInput StringType) ]
+        [ Define.Input ("last", Nullable IntType)
+          Define.Input ("before", Nullable StringType) ]
 
     /// <summary>
     /// Complete set of argument definitions for bidirectional pagination.

src/FSharp.Data.GraphQL.Server/Schema.fs

@@ -152,14 +152,14 @@ type SchemaConfig =
             let args = [|
                 Define.Input(
                     "interval",
-                    Nullable (IntType :> InputDef<int>),
+                    Nullable IntType,
                     defaultValue = streamOptions.Interval,
                     description = "An optional argument used to buffer stream results. " +
                         "When it's value is greater than zero, stream results will be buffered for milliseconds equal to the value, then sent to the client. " +
                         "After that, starts buffering again until all results are streamed.")
                 Define.Input(
                     "preferredBatchSize",
-                    Nullable (IntType :> InputDef<int>),
+                    Nullable IntType,
                     defaultValue = streamOptions.PreferredBatchSize,
                     description = "An optional argument used to buffer stream results. " +
                         "When it's value is greater than zero, stream results will be buffered until item count reaches this value, then sent to the client. " +

src/FSharp.Data.GraphQL.Shared/Introspection.fs

@@ -90,8 +90,8 @@ let rec __Type =
         fieldsFn =
             fun () -> [
                 Define.Field ("kind", __TypeKind, (fun _ t -> t.Kind))
-                Define.Field ("name", Nullable (StringType :> OutputDef<string>), resolve = (fun _ t -> t.Name))
-                Define.Field ("description", Nullable (StringType :> OutputDef<string>), resolve = (fun _ t -> t.Description))
+                Define.Field ("name", Nullable StringType, resolve = (fun _ t -> t.Name))
+                Define.Field ("description", Nullable StringType, resolve = (fun _ t -> t.Description))
                 Define.Field (
                     "fields",
                     Nullable (ListOf __Field),
@@ -173,9 +173,9 @@ and __InputValue =
         fieldsFn =
             fun () -> [
                 Define.Field ("name", StringType, resolve = (fun _ f -> f.Name))
-                Define.Field ("description", Nullable (StringType :> OutputDef<string>), resolve = (fun _ f -> f.Description))
+                Define.Field ("description", Nullable StringType, resolve = (fun _ f -> f.Description))
                 Define.Field ("type", __Type, resolve = (fun _ f -> f.Type))
-                Define.Field ("defaultValue", Nullable (StringType :> OutputDef<string>), (fun _ f -> f.DefaultValue))
+                Define.Field ("defaultValue", Nullable StringType, (fun _ f -> f.DefaultValue))
             ]
     )
 
@@ -189,11 +189,11 @@ and __Field =
         fieldsFn =
             fun () -> [
                 Define.Field ("name", StringType, (fun _ f -> f.Name))
-                Define.Field ("description", Nullable (StringType :> OutputDef<string>), (fun _ f -> f.Description))
+                Define.Field ("description", Nullable StringType, (fun _ f -> f.Description))
                 Define.Field ("args", ListOf __InputValue, (fun _ f -> f.Args))
                 Define.Field ("type", __Type, (fun _ f -> f.Type))
                 Define.Field ("isDeprecated", BooleanType, resolve = (fun _ f -> f.IsDeprecated))
-                Define.Field ("deprecationReason", Nullable (StringType :> OutputDef<string>), (fun _ f -> f.DeprecationReason))
+                Define.Field ("deprecationReason", Nullable StringType, (fun _ f -> f.DeprecationReason))
             ]
     )
 
@@ -208,9 +208,9 @@ and __EnumValue =
         fieldsFn =
             fun () -> [
                 Define.Field ("name", StringType, resolve = (fun _ e -> e.Name))
-                Define.Field ("description", Nullable (StringType :> OutputDef<string>), resolve = (fun _ e -> e.Description))
+                Define.Field ("description", Nullable StringType, resolve = (fun _ e -> e.Description))
                 Define.Field ("isDeprecated", BooleanType, resolve = (fun _ e -> Option.isSome e.DeprecationReason))
-                Define.Field ("deprecationReason", Nullable (StringType :> OutputDef<string>), resolve = (fun _ e -> e.DeprecationReason))
+                Define.Field ("deprecationReason", Nullable StringType, resolve = (fun _ e -> e.DeprecationReason))
             ]
     )
 
@@ -231,8 +231,8 @@ and __Directive =
         fieldsFn =
             fun () -> [
                 Define.Field ("name", StringType, resolve = (fun _ directive -> directive.Name))
-                Define.Field ("description", Nullable (StringType :> OutputDef<string>), resolve = (fun _ directive -> directive.Description))
-                Define.Field ("locations", ListOf (__DirectiveLocation :> OutputDef<DirectiveLocation>), resolve = (fun _ directive -> directive.Locations))
+                Define.Field ("description", Nullable StringType, resolve = (fun _ directive -> directive.Description))
+                Define.Field ("locations", ListOf __DirectiveLocation, resolve = (fun _ directive -> directive.Locations))
                 Define.Field ("args", ListOf __InputValue, resolve = (fun _ directive -> directive.Args))
                 Define.Field (
                     "onOperation",

src/FSharp.Data.GraphQL.Shared/SchemaDefinitions.fs

@@ -393,6 +393,7 @@ module SchemaDefinitions =
         | InlineConstant value -> value.GetCoerceError destinationType
 
     type TypeWrapperStaticDispatch =
+
         static member Nullable<'Val>(innerDef : InputOutputDef<'Val>) : NullableDef<'Val> =
             let ofType : TypeDef<'Val> = upcast innerDef
             upcast { NullableDefinition.OfType = ofType }