Skip to content

Commit 6d3340c

Browse files
Copilotxperiandri
andauthored
Address review feedback in introspection and swapi tests
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/4998e0af-9a24-4088-a9a9-3318b08f3de9 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
1 parent 3aeae66 commit 6d3340c

2 files changed

Lines changed: 25 additions & 3 deletions

File tree

tests/FSharp.Data.GraphQL.IntegrationTests/IntrospectionUpdateTests.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ let readDestinationDocumentAsync ct (stream : FileStream) =
3535
try
3636
let! document = JsonDocument.ParseAsync (stream, cancellationToken = ct)
3737
return ValueSome document
38-
with _ ->
38+
with :? JsonException ->
3939
return ValueNone
4040
}
4141

tests/FSharp.Data.GraphQL.IntegrationTests/SwapiRemoteProviderTests.fs

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,18 @@ hero (id: "1000") {
5151
result.Data.Value.Hero.IsSome |> equals true
5252
result.Data.Value.Hero.Value.AppearsIn |> equals [| Episode.NewHope; Episode.Empire; Episode.Jedi |]
5353
let friends = result.Data.Value.Hero.Value.Friends.Edges |> Array.map (fun e -> e.Node)
54-
friends |> hasItems
54+
friends.Length |> equals 4
55+
friends[0].IsHuman() |> equals true
56+
friends[0].AsHuman().Name |> equals (Some "Han Solo")
57+
friends[1].IsHuman() |> equals true
58+
friends[1].AsHuman().Name |> equals (Some "Leia Organa")
59+
friends[1].AsHuman().HomePlanet |> equals (Some "Alderaan")
60+
friends[2].IsDroid() |> equals true
61+
friends[2].AsDroid().Name |> equals (Some "C-3PO")
62+
friends[2].AsDroid().PrimaryFunction |> equals (Some "Protocol")
63+
friends[3].IsDroid() |> equals true
64+
friends[3].AsDroid().Name |> equals (Some "R2-D2")
65+
friends[3].AsDroid().PrimaryFunction |> equals (Some "Astromech")
5566
result.Data.Value.Hero.Value.HomePlanet |> equals (Some "Tatooine")
5667
let actual = normalize <| sprintf "%A" result.Data
5768
let expected = normalize <| """Some
@@ -168,7 +179,18 @@ module FileOperation =
168179
result.Data.Value.Hero.IsSome |> equals true
169180
result.Data.Value.Hero.Value.AppearsIn |> equals [| Episode.NewHope; Episode.Empire; Episode.Jedi |]
170181
let friends = result.Data.Value.Hero.Value.Friends.Edges |> Array.map _.Node
171-
friends |> hasItems
182+
friends.Length |> equals 4
183+
friends[0].IsHuman() |> equals true
184+
friends[0].AsHuman().Name |> equals (Some "Han Solo")
185+
friends[1].IsHuman() |> equals true
186+
friends[1].AsHuman().Name |> equals (Some "Leia Organa")
187+
friends[1].AsHuman().HomePlanet |> equals (Some "Alderaan")
188+
friends[2].IsDroid() |> equals true
189+
friends[2].AsDroid().Name |> equals (Some "C-3PO")
190+
friends[2].AsDroid().PrimaryFunction |> equals (Some "Protocol")
191+
friends[3].IsDroid() |> equals true
192+
friends[3].AsDroid().Name |> equals (Some "R2-D2")
193+
friends[3].AsDroid().PrimaryFunction |> equals (Some "Astromech")
172194
result.Data.Value.Hero.Value.HomePlanet |> equals (Some "Tatooine")
173195
let actual = normalize <| sprintf "%A" result.Data
174196
let expected = normalize <| """Some

0 commit comments

Comments
 (0)