Apply follow-up review suggestions

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/f1a0e6cb-a5dd-40d9-a7dc-28e030b8e56f

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Author: Copilot

docs/execution-pipeline.md

@@ -52,7 +52,7 @@ The execution phase can be performed using one of the two strategies:
 
 The result of a GraphQL query execution is a `GQLResponse` object with the following fields:
 
-- `documentId`: deterministic SHA-256 hash (lowercase hex string) of the canonical query document - it can be used to implement execution plan caching (persistent queries).
+- `documentId`: deterministic SHA-256 hash (lowercase hex string) of the canonical query document – it can be used to implement execution plan caching (persistent queries).
 - `data`: optional, a formatted GraphQL response matching the requested query (`KeyValuePair seq`). Absent in case of an error that does not allow continuing processing and returning any GraphQL results.
 - `errors`: optional, contains a list of errors (`GQLProblemDetails`) that occurred during query execution.
 

src/FSharp.Data.GraphQL.Client.DesignTime/ProvidedTypesHelper.fs

@@ -799,7 +799,7 @@ module internal Provider =
                                     match validationResult with
                                     | ValidationError msgs -> failwith (formatValidationExceptionMessage msgs)
                                     | Success -> ()
-                                let key = { DocumentId = DocumentId.fromDocument queryAst; SchemaId = schema.GetHashCode() }
+                                let key = { DocumentId = DocumentId.fromCanonicalQuery (queryAst.ToQueryString()); SchemaId = schema.GetHashCode() }
                                 let refMaker = lazy Validation.Ast.validateDocument schema queryAst
                                 if clientQueryValidation then
                                     refMaker.Force

src/FSharp.Data.GraphQL.Server/Executor.fs

@@ -79,10 +79,6 @@ type Executor<'Root>(schema: ISchema<'Root>, middlewares : IExecutorMiddleware s
 
     let middlewaresList = Seq.toList middlewares
 
-    /// Generates a deterministic document identifier from the canonical query string.
-    let getDocumentId (document : Document) =
-        DocumentId.fromDocument document
-
     let rec runMiddlewares (phaseSel : IExecutorMiddleware -> ('ctx -> ('ctx -> 'res) -> 'res) option)
                            (initialCtx : 'ctx)
                            (onComplete : 'ctx -> 'res)
@@ -143,7 +139,7 @@ type Executor<'Root>(schema: ISchema<'Root>, middlewares : IExecutorMiddleware s
         eval (executionPlan, data, variables, getInputContext)
 
     let createExecutionPlan (ast: Document, operationName: string option, meta : Metadata) =
-        let documentId = getDocumentId ast
+        let documentId = DocumentId.fromCanonicalQuery (ast.ToQueryString())
         result {
             match findOperation ast operationName with
             | Some operation ->

src/FSharp.Data.GraphQL.Shared/FSharp.Data.GraphQL.Shared.fsproj

@@ -49,13 +49,13 @@
     <Compile Include="Helpers\Extensions.fs" />
     <Compile Include="Helpers\Reflection.fs" />
     <Compile Include="Helpers\MemoryCache.fs" />
+    <Compile Include="Helpers\DocumentId.fs" />
     <Compile Include="Errors.fs" />
     <Compile Include="Exception.fs" />
     <Compile Include="ValidationTypes.fs" />
     <Compile Include="AsyncVal.fs" />
     <Compile Include="Ast.fs" />
     <Compile Include="AstExtensions.fs" />
-    <Compile Include="Helpers\DocumentId.fs" />
     <Compile Include="TypeSystem.fs" />
     <Compile Include="SchemaDefinitions.fs" />
     <Compile Include="SchemaDefinitionsExtensions.fs" />

src/FSharp.Data.GraphQL.Shared/Helpers/DocumentId.fs

@@ -3,17 +3,14 @@ module FSharp.Data.GraphQL.DocumentId
 open System.Globalization
 open System.Security.Cryptography
 open System.Text
-open FSharp.Data.GraphQL.Ast
-open FSharp.Data.GraphQL.Ast.Extensions
 
 let private formatByteAsLowerHex (value : byte) =
     value.ToString("x2", CultureInfo.InvariantCulture)
 
-let fromDocument (document : Document) =
-    let canonicalQuery = document.ToQueryString()
+let fromCanonicalQuery (canonicalQuery : string) =
     let queryBytes = Encoding.UTF8.GetBytes canonicalQuery
     use sha256 = SHA256.Create()
     let hash = sha256.ComputeHash queryBytes
     hash
-    |> Array.map formatByteAsLowerHex
+    |> Seq.map formatByteAsLowerHex
     |> String.concat ""