Fixed double variables coercion

Author: xperiandri

src/FSharp.Data.GraphQL.Server.Middleware/MiddlewareDefinitions.fs

@@ -90,6 +90,7 @@ type internal ObjectListFilterMiddleware<'ObjectType, 'ListType>(reportToMetadat
                         match x.Name with
                         | "filter" -> ObjectListFilter.CoerceInput (InlineConstant x.Value)
                         | _ -> Ok NoFilter)
+                    |> Seq.toList
                 match filterResults |> splitSeqErrorsList with
                 | Error errs -> Error errs
                 | Ok filters ->

src/FSharp.Data.GraphQL.Server.Middleware/SchemaDefinitions.fs

@@ -69,7 +69,8 @@ module SchemaDefinitions =
 
         let rec mapFilter (name : string, value : InputValue) =
             let mapFilters fields =
-                let coerceResults = fields |> Seq.map coerceObjectListFilterInput |> splitSeqErrorsList
+                let coerceResults =
+                    fields |> Seq.map coerceObjectListFilterInput |> Seq.toList |> splitSeqErrorsList
                 match coerceResults with
                 | Error errs -> Error errs
                 | Ok coerced -> coerced |> removeNoFilter |> Seq.toList |> Ok
@@ -95,7 +96,8 @@ module SchemaDefinitions =
             | _ -> Ok NoFilter
 
         and mapInput value =
-            let filterResults = value |> Map.toSeq |> Seq.map mapFilter |> splitSeqErrorsList
+            let filterResults =
+                value |> Map.toSeq |> Seq.map mapFilter |> Seq.toList |> splitSeqErrorsList
             match filterResults with
             | Error errs -> Error errs
             | Ok filters ->

src/FSharp.Data.GraphQL.Server/ErrorsProcessing.fs

@@ -11,10 +11,10 @@ open FsToolkit.ErrorHandling
 
 let getObjectErrors (object: IReadOnlyDictionary<string, Result<'t, IGQLError>>) =
     object
-    |> Seq.choose (fun kvp ->
+    |> Seq.vchoose (fun kvp ->
         match kvp.Value with
-        | Ok _ -> None
-        | Error err -> Some err)
+        | Ok _ -> ValueNone
+        | Error err -> ValueSome err)
     |> Seq.toList
 
 let getObjectValues (object: IReadOnlyDictionary<string, Result<'t, IGQLError>>) =
@@ -30,18 +30,19 @@ let getObjectValues (object: IReadOnlyDictionary<string, Result<'t, IGQLError>>)
 let splitObjectErrors (object: IReadOnlyDictionary<string, Result<'t, IGQLError>>) =
     let errors = object |> getObjectErrors
 
-    if not <| List.isEmpty errors then
+    if not errors.IsEmpty then
         Error errors
     else
         let values = object |> getObjectValues
         Ok values
 
 let getObjectErrorsList (object: IReadOnlyDictionary<string, Result<'t, IGQLError list>>) =
     object
-    |> Seq.choose (fun kvp ->
+    |> Seq.vchoose (fun kvp ->
         match kvp.Value with
-        | Ok _ -> None
-        | Error err -> Some err)
+        | Ok _ -> ValueNone
+        | Error err -> ValueSome err)
+    |> Seq.collect id
     |> Seq.toList
 
 let getObjectValuesList (object: IReadOnlyDictionary<string, Result<'t, IGQLError list>>) =
@@ -57,18 +58,18 @@ let getObjectValuesList (object: IReadOnlyDictionary<string, Result<'t, IGQLErro
 let splitObjectErrorsList (object: IReadOnlyDictionary<string, Result<'t, IGQLError list>>) =
     let errors = object |> getObjectErrorsList
 
-    if not <| List.isEmpty errors then
-        Error (errors |> List.collect id)
+    if not errors.IsEmpty then
+        Error errors
     else
         let values = object |> getObjectValuesList
         Ok values
 
 let getSeqErrors (items: Result<'t, IGQLError> seq) =
     items
-    |> Seq.choose (fun result ->
+    |> Seq.vchoose (fun result ->
         match result with
-        | Ok _ -> None
-        | Error err -> Some err)
+        | Ok _ -> ValueNone
+        | Error err -> ValueSome err)
     |> Seq.toList
 
 let getSeqValues (items: Result<'t, IGQLError> seq) =
@@ -79,21 +80,22 @@ let getSeqValues (items: Result<'t, IGQLError> seq) =
         | Error _ -> raise <| ArgumentException())
     |> Seq.toArray
 
-let splitSeqErrors (items: Result<'t, IGQLError> seq) =
+let splitSeqErrors (items: Result<'t, IGQLError> list) =
     let errors = items |> getSeqErrors
 
-    if not <| List.isEmpty errors then
+    if not errors.IsEmpty then
         Error errors
     else
         let values = items |> getSeqValues
         Ok values
 
 let getSeqErrorsList (items: Result<'t, IGQLError list> seq) =
     items
-    |> Seq.choose (fun result ->
+    |> Seq.vchoose (fun result ->
         match result with
-        | Ok _ -> None
-        | Error err -> Some err)
+        | Ok _ -> ValueNone
+        | Error err -> ValueSome err)
+    |> Seq.collect id
     |> Seq.toList
 
 let getSeqValuesList (items: Result<'t, IGQLError list> seq) =
@@ -104,11 +106,11 @@ let getSeqValuesList (items: Result<'t, IGQLError list> seq) =
         | Error _ -> raise <| ArgumentException())
     |> Seq.toArray
 
-let splitSeqErrorsList (items: Result<'t, IGQLError list> seq) =
+let splitSeqErrorsList (items: Result<'t, IGQLError list> list) =
     let errors = items |> getSeqErrorsList
 
-    if not <| List.isEmpty errors then
-        Error (errors |> List.collect id)
+    if not errors.IsEmpty then
+        Error errors
     else
         let values = items |> getSeqValuesList
         Ok values

src/FSharp.Data.GraphQL.Server/Values.fs

@@ -208,6 +208,7 @@ let rec internal compileByType
                                 |> Result.map (normalizeOptional param.ParameterType)
                                 |> attachErrorExtensionsIfScalar inputSource inputObjectPath originalInputDef field
                         | ValueNone -> Ok <| wrapOptionalNone param.ParameterType typeof<obj>)
+                    |> Seq.toList
 
                 let! args = argResults |> splitSeqErrorsList
 
@@ -237,6 +238,7 @@ let rec internal compileByType
                                     return normalizeOptional param.ParameterType value
                                 | ValueNone -> return wrapOptionalNone param.ParameterType typeof<obj>
                             })
+                            |> Seq.toList
 
                         let! args = argResults |> splitSeqErrorsList
 
@@ -280,6 +282,7 @@ let rec internal compileByType
                 let! mappedValues =
                     list
                     |> Seq.mapi (fun i value -> inner i value variables)
+                    |> Seq.toList
                     |> splitSeqErrorsList
                 let mappedValues =
                     mappedValues
@@ -430,6 +433,7 @@ let rec internal coerceVariableValue
                             input.EnumerateArray ()
                             |> Seq.mapi (fun i elem ->
                                 coerceVariableValue areItemsNullable ((box i) :: inputObjectPath) ValueNone (originalTypeDef, innerDef) varDef elem)
+                            |> Seq.toList
                             |> splitSeqErrorsList
                         if areItemsNullable then
                             let some, none, _ = ReflectionHelper.optionOfType innerDef.Type.GenericTypeArguments[0]

src/FSharp.Data.GraphQL.Shared/Helpers/ObjAndStructConversions.fs

@@ -27,3 +27,7 @@ module internal Seq =
 module internal List =
 
     let vchoose mapping list = list |> Seq.vchoose mapping |> List.ofSeq
+
+module internal Array =
+
+    let vchoose mapping array = array |> Seq.vchoose mapping |> Array.ofSeq